Revised text of checkbox "auto primary key", and disabled the

aggregation function of the measure if the option is checked. - Bugzilla Bug (s) Resolved: None - Description:
eclipse-birt · Nov 1, 2011 · ae8ddd0 · ae8ddd0
1 parent abb7235
commit ae8ddd0
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/...cubebuilder/src/org/eclipse/birt/report/designer/ui/cubebuilder/dialog/MeasureDialog.java b/...cubebuilder/src/org/eclipse/birt/report/designer/ui/cubebuilder/dialog/MeasureDialog.java
@@ -73,6 +73,7 @@ public class MeasureDialog extends TitleAreaDialog
 {
 
 	private boolean isEdit = false;
+	private boolean isAutoPrimaryKeyChecked = false;
 	private Combo typeCombo;
 	private Text expressionText;
 	private Combo functionCombo;
@@ -198,6 +199,11 @@ public void setInput( TabularMeasureHandle input )
 		this.input = input;
 	}
 
+	public void setAutoPrimaryKeyStatus( boolean isChecked )
+	{
+		this.isAutoPrimaryKeyChecked = isChecked;
+	}
+
 	/*
 	 * (non-Javadoc) Method declared on Dialog.
 	 */
@@ -485,6 +491,7 @@ public void widgetSelected( SelectionEvent e )
 			}
 
 		} );
+		functionCombo.setEnabled( !isAutoPrimaryKeyChecked );
 
 		Label typeLabel = new Label( group, SWT.NONE );
 		typeLabel.setText( Messages.getString( "MeasureDialog.Label.DataType" ) ); //$NON-NLS-1$
@@ -519,7 +526,6 @@ public void widgetSelected( SelectionEvent e )
 			public void modifyText( ModifyEvent e )
 			{
 				checkOkButtonStatus( );
-
 			}
 
 		} );

diff --git a/...i.cubebuilder/src/org/eclipse/birt/report/designer/ui/cubebuilder/nls/messages.properties b/...i.cubebuilder/src/org/eclipse/birt/report/designer/ui/cubebuilder/nls/messages.properties
@@ -75,7 +75,7 @@ SimpleCubeBuilder.Title.Title=Cross Tab Cube Builder
 SimpleCubeBuilder.Title.Message=Organize your data for the cross tab by specifying grouping hierarchies and summary data fields.
 SimpleCubeBuilder.Title=Cross Tab Cube Builder
 SimpleCubeBuilder.Label.Name=Name:
-DatasetSelectionPage.Label.Auto.Primary.Key=&Check this option if the data in the primary dataset has been grouped and aggregated in a way that matches the cube definition.
+DatasetSelectionPage.Label.Auto.Primary.Key=&Check this option to avoid preaggregation in primary data set during cube generation.
 DatasetSelectionPage.Text.Auto.Primary.Key=Hint - If this option is checked, BIRT will skip the grouping and aggregation calculation during cube generation to achieve better cube generation performance.
 DatasetSelectionPage.Combo.NewDataSet0=<New Data Set...>
 GroupsPage.Button.Add=&Add

diff --git a/...ubebuilder/src/org/eclipse/birt/report/designer/ui/cubebuilder/page/CubeGroupContent.java b/...ubebuilder/src/org/eclipse/birt/report/designer/ui/cubebuilder/page/CubeGroupContent.java
@@ -687,6 +687,7 @@ public void drop( DropTargetEvent event )
 									{
 										MeasureDialog dialog = new MeasureDialog( false );
 										dialog.setInput( measure );
+										dialog.setAutoPrimaryKeyStatus( input.autoPrimaryKey( ) );
 										if ( dialog.open( ) == Window.CANCEL )
 										{
 											SessionHandleAdapter.getInstance( )
@@ -792,6 +793,7 @@ else if ( element instanceof LevelHandle )
 									{
 										MeasureDialog dialog = new MeasureDialog( false );
 										dialog.setInput( measure );
+										dialog.setAutoPrimaryKeyStatus( input.autoPrimaryKey( ) );
 										if ( dialog.open( ) == Window.CANCEL )
 										{
 											SessionHandleAdapter.getInstance( )
@@ -865,6 +867,7 @@ else if ( element instanceof MeasureGroupHandle
 									{
 										MeasureDialog dialog = new MeasureDialog( false );
 										dialog.setInput( measure );
+										dialog.setAutoPrimaryKeyStatus( input.autoPrimaryKey( ) );
 										if ( dialog.open( ) == Window.CANCEL )
 										{
 											SessionHandleAdapter.getInstance( )
@@ -1681,6 +1684,7 @@ private void handleAddEvent( )
 								measure );
 						MeasureDialog dialog = new MeasureDialog( true );
 						dialog.setInput( measure );
+						dialog.setAutoPrimaryKeyStatus( input.autoPrimaryKey( ) );
 						if ( dialog.open( ) == Window.CANCEL )
 						{
 							stack.rollback( );
@@ -1709,6 +1713,7 @@ else if ( obj instanceof MeasureHandle )
 								.add( IMeasureGroupModel.MEASURES_PROP, measure );
 						MeasureDialog dialog = new MeasureDialog( true );
 						dialog.setInput( measure );
+						dialog.setAutoPrimaryKeyStatus( input.autoPrimaryKey( ) );
 						if ( dialog.open( ) == Window.CANCEL )
 						{
 							stack.rollback( );
@@ -2185,6 +2190,7 @@ else if ( obj instanceof DimensionHandle
 							{
 								MeasureDialog dialog = new MeasureDialog( false );
 								dialog.setInput( measure );
+								dialog.setAutoPrimaryKeyStatus( input.autoPrimaryKey( ) );
 								if ( dialog.open( ) == Window.CANCEL )
 								{
 									stack.rollback( );
@@ -2239,6 +2245,7 @@ else if ( obj instanceof MeasureHandle )
 							{
 								MeasureDialog dialog = new MeasureDialog( false );
 								dialog.setInput( measure );
+								dialog.setAutoPrimaryKeyStatus( input.autoPrimaryKey( ) );
 								if ( dialog.open( ) == Window.CANCEL )
 								{
 									stack.rollback( );
@@ -2463,6 +2470,7 @@ else if ( obj instanceof TabularMeasureHandle )
 				stack.startTrans( "" ); //$NON-NLS-1$
 				MeasureDialog dialog = new MeasureDialog( false );
 				dialog.setInput( level );
+				dialog.setAutoPrimaryKeyStatus( input.autoPrimaryKey( ) );
 				if ( dialog.open( ) == Window.OK )
 				{
 					stack.commit( );