Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to import BIRT code into eclipse #628

Closed
SteveSchafer-Innovent opened this issue Mar 31, 2021 · 108 comments
Closed

How to import BIRT code into eclipse #628

SteveSchafer-Innovent opened this issue Mar 31, 2021 · 108 comments
Assignees
Milestone

Comments

@SteveSchafer-Innovent
Copy link
Contributor

I have not been successful at importing the BIRT code into eclipse without there being errors. I've tried several methods of importing, including importing existing project at the root level, importing existing project for each individual project, and importing existing maven project at the root level, with varying results. I'd like to know if anyone has been able to get the code imported without any errors and specifically how to do it.

@patric-r
Copy link

patric-r commented Apr 6, 2021

+1

Same here.
Ideally we would have a document describing how to set up a correct and working build environment within eclipse.
Building BIRT within Eclipse is an important prerequisite of doing changes, fixing bugs and issuing PRs
(I'm wondering if the main developers are building BIRT solely with maven?).

IMHO, this is much more important than other things currently discussed (e.g. having a new logo/website).

@ruspl-afed
Copy link
Contributor

@Flugtiger mentioned oomph setup script. I don't know if he still plans to submit it but this would be very helpful.

@patric-r
Copy link

patric-r commented Apr 6, 2021

A working oomph script would be helpful.

@ruspl-afed How does your BIRT development environment currently look like?

@ruspl-afed
Copy link
Contributor

What I did:

(should be covered by oomph)

  1. imported all project as "General" from cloned repo
  2. switched target to /org.eclipse.birt.target/org.eclipse.birt.target.target
  3. switched workspace preference "Missed API Baseline" to warning

(plan to contribute it after tests will be fixed for master)

  1. added lifycycle mapping ignorance to /org.eclipse.birt.report.viewer/pom.xml
  2. changed VM to 1.8 for nl fragments

@patric-r
Copy link

patric-r commented Apr 6, 2021

Thanks. Which Java version/Eclipse SDK release needs to be currently used?
(Having all those information in a single document would be really helpful to the community)

@ruspl-afed
Copy link
Contributor

Java 8 is important at the moment, but there is a plan to upgrade to Java 11.
I'm using the latest released Eclipse for Committers package for development.
The dependencies are specified in the target.

@SteveSchafer-Innovent
Copy link
Contributor Author

SteveSchafer-Innovent commented Apr 7, 2021

Here's what I did.

  1. general / import existing project - select root of cloned repo. If I do not check "Search for nested projects", I get a tree view which doesn't show packages and no errors. If I check "Search for nested projects", it tells me a couple of projects cannot be imported because they already exist. Then I end up with a lot of projects and 154 errors, a lot of which are lifecycle errors.
  2. I changed the lifecycle error to a warning in the workspace because I didn't want to make any changes to the repo.
  3. That gets me down to 143 errors, most of which are about projects that cannot be built until their prerequisites are built. The others are various packages and/or classes that cannot be resolved. Then after a few minutes (while I'm typing this), it decides to rebuild on its own and then I have 53 errors, most of which are "Access restriction ... is not API ...", which I can change to warnings. After that I'm down to 17 errors which is about as low as I've been able to get it.

I think that at least some of the unresolved classes and packages may be due misconfigured java build path (e.g. no source folder), java packages no longer supported (javax.xml.bind), and J2SE-1.5 execution environment. All of these can be fixed in due course.

I do have one really weird error where it's obviously trying to unzip a pom.xml file. It seems to be caused by an unpack goal in the maven-dependency-plugin in birt-runtime-test. No idea why it's doing that.

I also have "An API baseline has not been set for the current workspace". I've tried setting it to org.eclipse.birt.target.target but that gives me "There is a possible API baseline mismatch since none of the workspace projects is in the baseline", so that probably wan't the right thing to do.
Anyway sorry for the long-winded comment but if anyone sees anything I'm obviously doing wrong, please let me know.

@ruspl-afed
Copy link
Contributor

I also have "An API baseline has not been set for the current workspace". I've tried setting it to org.eclipse.birt.target.target but that gives me "There is a possible API baseline mismatch since none of the workspace projects is in the baseline", so that probably wan't the right thing to do.

We don't have API baseline defined yet, but we need to create one that points to the latest officially released BIRT. @wimjongman do we know the git tag and the p2 repo URL of the latest official BIRT release?

@patric-r
Copy link

I still cannot get it to work. I used the most recent eclipse-for-commiters package, like @ruspl-afed said.
I did it like @SteveSchafer-Innovent said, using "search nested projects" on the git repo.

I have more than 20000 compile errors (e.g. org.eclipse.emf cannot be resolved - although I installled EMF, com.lowagie cannot be resolved - but when I click on the imports, the source file is opened. This really looks like a configuration error.
Any help is appreciated.

IMHO, if BIRT want to encourage other developers, the project really needs a document how to setup a proper build/development environment. Currently, it is very frustrating.

@wimjongman
Copy link
Contributor

wimjongman commented Apr 12, 2021

We don't have API baseline defined yet, but we need to create one that points to the latest officially released BIRT. @wimjongman do we know the git tag and the p2 repo URL of the latest official BIRT release?

I see this release directory R-R1-4.8.0-201806261756. There is no tag for it but I expect it is commit 8e9ce5f.

So tag BIRT_4_8_0_Release_201806261756 must be made out of commit 8e9ce5f

@wimjongman
Copy link
Contributor

I don't have the authority to do that. I expect this can only be done by project leads.

@ruspl-afed
Copy link
Contributor

I have more than 20000 compile errors (e.g. org.eclipse.emf cannot be resolved - although I installled EMF, com.lowagie cannot be resolved - but when I click on the imports, the source file is opened. This really looks like a configuration error.
Any help is appreciated.

What target do you use? Please try with

/org.eclipse.birt.target/org.eclipse.birt.target.target

@patric-r
Copy link

@ruspl-afed Thanks,

I opened /org.eclipse.birt.target/org.eclipse.birt.target.target
and clicked on "Set as Active Target Platform".

This dropped the error count down to 1052. Good!
Most of them are maven errors of the following group (all nested projects seem to be affected):

  • "Plugin execution not covered by lifecycle configuration: org.apache.maven.plugins:maven-antrun-plugin:1.8:run (execution: generate.property.files, phase: compile)" errors
  • Plugin execution not covered by lifecycle configuration: org.eclipse.tycho:tycho-packaging-plugin:1.0.0:build-qualifier (execution: default-build-qualifier, phase: validate)
  • Plugin execution not covered by lifecycle configuration: org.eclipse.tycho:tycho-packaging-plugin:1.0.0:build-qualifier-aggregator (execution: default-build-qualifier-aggregator, phase: validate)
  • Plugin execution not covered by lifecycle configuration: org.eclipse.tycho:tycho-packaging-plugin:1.0.0:validate-id (execution: default-validate-id, phase: validate)
  • Plugin execution not covered by lifecycle configuration: org.eclipse.tycho:tycho-packaging-plugin:1.0.0:validate-version (execution: default-validate-version, phase: validate)

Any hints are appreciated.

@wimjongman
Copy link
Contributor

If you open the problems view, you can select the "..lifecycle.." error.

It enables you to download a couple of extra plugins. If that does not solve it, it also enables you to silence the errors in the preferences. Eclipse is running its own compile anyway.

@patric-r
Copy link

Thank you so much, @wimjongman !

I used quick fix->Discover new m2e connectors
to resolve most dependencies:

Down to 89 errors.

But not all of them:

  • Plugin execution not covered by lifecycle configuration: org.apache.maven.plugins:maven-antrun-plugin:1.8:run (execution: generate.property.files, phase: compile)

When using Quick fix, it shows me:
No marketplace entries found to handle Execution generate.property.files, in /org.eclipse.birt.report.engine.emitter.config.nl/pom.xml in Eclipse. Please see Help for more information.

In addition to the maven errors, I have a few others:

  • Java compiler level does not match the version of the installed Java project facet.
  • An API baseline has not been set for the current workspace.
  • The import org.eclipse.birt.chart.viewer cannot be resolved (org.eclipse.birt.chart.viewer/WebContent/drill)
  • SampleHelper cannot be resolved (org.eclipse.birt.chart.viewer/WebContent)
  • The method accept(File, String) of type new FilenameFilter(){} must override a superclass method (birt-runtime-test/src/test/java/org/eclipse/birt/sdk)

@wimjongman
Copy link
Contributor

Can you start to write a "getting started" document that explains all steps?

@patric-r
Copy link

@wimjongman
I can try to do this but at first I would need to have a working development environment in order to document all steps.
It would be nice if you (or someone else) would assist me to solve the remaining issues.

@ruspl-afed
Copy link
Contributor

Plugin execution not covered by lifecycle configuration: org.apache.maven.plugins:maven-antrun-plugin:1.8:run (execution: generate.property.files, phase: compile)

please choose "Ignore" Quick Fix for this

An API baseline has not been set for the current workspace.

Since we don't have baseline defined at the moment let's set this error to warning in preferences

As for java version related problem I fixed a number of them in master, but perhaps not all

@patric-r
Copy link

Instead of ignoring, why can't we fix the root cause of those issues?

What about the other issues?

@wimjongman
Copy link
Contributor

Go to the root of the git repo and run the build. This might resolve some of the compile issues.

mvn clean verify -DskipTests

@ruspl-afed
Copy link
Contributor

Instead of ignoring, why can't we fix the root cause of those issues?

To fix the root cause we will need to implement a maven to eclipse lifecycle mapping for this maven plugin. I think this is out of scope for this project.

What about the other issues?

Please update us with the list of issues you still have after building the latest master with

mvn clean verify -DskipTests

as @wimjongman suggested

@patric-r
Copy link

mvn clean verify -DskipTests fails very strangely with many errors.... First of them is:

[ERROR] C:\Users\github\git\birt\viewer\org.eclipse.birt.axis.overlay\src\org\eclipse\birt\axis\utility\UTF8Encoder.java:[1]
[ERROR]         /*
[ERROR]         ^
[ERROR] The type java.lang.Object cannot be resolved. It is indirectly referenced from required .class files

@wimjongman
Copy link
Contributor

wimjongman commented Apr 15, 2021

Yes, it needs to be run with JDK 8. I am working on a > JDK8 (JDK11) build and I am one failing test away from success.

Please try to run the same with branch prepare_for_java11

@patric-r
Copy link

@wimjongman Thanks, running maven with a JDK 8 worked.
The command mvn clean verify -DskipTests ran without any errors.

However, the situation didn't change in eclipse. Even after refreshing and doing a clean build, I still have 89 errors.

@wimjongman
Copy link
Contributor

What errors are left?

@wimjongman
Copy link
Contributor

We just released a new build. Please update BIRT and check the remaining errors. BIRT build must now be done with JDK11+

@patric-r
Copy link

patric-r commented Apr 15, 2021

@wimjongman mvn verify goal with JDK 11 works after pulling the newest changes.
However, eclipse now shows ~5800 errors again.

Now we are back on all those "package org.w3c.dom is accessible from more than one module: , java.xml" errors.

Aren't you getting those errors in your eclipse?

@wimjongman
Copy link
Contributor

Please try Project/Clean.. Clean all projects.

@patric-r
Copy link

patric-r commented Apr 15, 2021

I already did this. I refreshed maven configuration, I closed the projects and re-opened it, ran clean all - the result is the same.

@wimjongman
Copy link
Contributor

Ok, let me try on a fresh workspace.

@wimjongman
Copy link
Contributor

The "baseline workflow" is a method to prevent undocumented API changes.

How does it work:

  1. Download the previous BIRT release (download the all-in-one from here
  2. Unzip this in a known location e.g. ~user/eclipse/baselines/
  3. Goto preferences/plugin development/API Baseline and add the unzipped directory there

Now Eclipse can compare 4.8 to 4.9 and warn us for undocumented API changes.

@patric-r
Copy link

So the "baseline" is a method to ensure that certain projects are API compatible to a specific, e.g. older eclipse release (different to the eclipse SDK which we are using for development) to ensure BIRT will run on those releases as well?

With "all-in-one" you mean birt-report-designer-all-in-one-4.8.0-20190521-win32.win32.x86_64.zip?

Is this something every contributor needs to do in order to properly compile, change and test a working copy of birt?

@wimjongman
Copy link
Contributor

So the "baseline" is a method to ensure that certain projects are API compatible to a specific, e.g. older eclipse release (different to the eclipse SDK which we are using for development) to ensure BIRT will run on those releases as well?

Not so much to an older Eclipse release but more to an older BIRT release. If we want BIRT to run against the API of an older Eclipse release then we have to build against that version. The current target platform runs against the latest Eclipse version. This means that we now can use new Eclipse API that would prevent BIRT from running on older Eclipse releases.

However, I have no intention to support older Eclipse releases. For that, we have BIRT 4.8.

The other reason is that any new BIRT API is properly documented with a "@SInCE" tag. If this is not the case then the baseline will complain. Try adding a new API (e.g. public method) to a project that uses the baseline and you will see an error appearing.

With "all-in-one" you mean birt-report-designer-all-in-one-4.8.0-20190521-win32.win32.x86_64.zip?

Yes,

Is this something every contributor needs to do in order to properly compile, change and test a working copy of birth?

The error is an error for Eclipse but it does not prevent running BIRT. The error can also be switched off in the preferences. Also, the lifecycle errors that you got are just logical errors as far as Eclipse is concerned. It does not hinder the execution of BIRT from within Eclipse.

wimjongman added a commit that referenced this issue Oct 29, 2021
Fixed javadoc generation
Fixed pom warning
@wimjongman
Copy link
Contributor

wimjongman commented Oct 29, 2021

With my latest push also the build is working again. Run maven with a java11 SDK. On the command line:

mvn package -DskipTests

@wimjongman
Copy link
Contributor

After the build, you will find the created products in the

 ../build/birt-packages/ 

directory

wimjongman added a commit that referenced this issue Oct 29, 2021
Synchronized with master
@wimjongman
Copy link
Contributor

build failing again after merge with master

wimjongman added a commit that referenced this issue Oct 29, 2021
Fixed build after merge with master
@merks
Copy link
Contributor

merks commented Oct 30, 2021

I've tried to write Oomph setup in the current state, as observed above, it's hard to even do this manually.

For /org.eclipse.birt.chart.device.pdf/META-INF/MANIFEST.MF lib/fop-2.3.jar is missing.
For /org.eclipse.birt.build/META-INF/MANIFEST.MF lib/dom4j-1.6.1.jar is missing.

You can't really build with compliance set to Java 11 because it complains about APIs being visible from multiple different modules.

You need a Java 8, JDK, and you need to tools.jar on the classpath or the com.sun.jdi* things don't resolve

For /org.eclipse.birt.data.oda.pojo.ui/META-INF/MANIFEST.MF the Fragment-Host doesn't resolve, it should probably be Fragment-Host: org.eclipse.birt.data.oda.pojo;bundle-version="[2.1.0,5.0.0)" instead.

For org.eclipse.birt.report.debug.internal.ui.launcher.util.ReportLauncherUtils.getEclipseHome() it should probably be like this

	public static IPath getEclipseHome() {
		return new Path(TargetPlatform.getLocation());
	}

For org.eclipse.birt.report.viewer.mock.ServletContextSimulator it should implement more 'newer' methods.

And of course all the Maven errors should be disabled, at least for now...

There's also the issue of Jetty dependencies and where to get those. The ones proved by the platform/SimRel aren't all the ones that are needed...

Given that things are in a state of flux and are quite badly broken, it's not really so feasible to automate the setup process at the moment.

I fixed some of the problems above via the setup, but others I had to fix manually. In the end, I do have an error-free workspace...

@ruspl-afed
Copy link
Contributor

Thank you so much Ed @merks for investing your time. I was creating setup in parallel, but may be I can continue from your variant. Do you plan to create a PR?

@merks
Copy link
Contributor

merks commented Oct 30, 2021

I'm familiar with the Gerrit workflow but I don't know how to do this with forks and pull requests. I'll just attach the work in progress here as a zip. It's mostly just boiler plate and the JRE task isn't much good because it only works with Java 8 right now...

BIRT.setup.zip

wimjongman added a commit that referenced this issue Oct 30, 2021
* How to import BIRT code into eclipse #628

Add project set for easy import

* How to import BIRT code into eclipse #628

Add project set for easy import

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6
Added preferences for engine.odf and engine.odp

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6
Added preferences for engine.odf and engine.odp, and many others

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6
Added preferences for engine.odf and engine.odp, and many others

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6
Added preferences for engine.odf and engine.odp, and many others

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6
Added preferences for engine.odf and engine.odp, and many others

* How to import BIRT code into eclipse #628

Add project set for easy import

* How to import BIRT code into eclipse #628

Add project set for easy import

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6
Added preferences for engine.odf and engine.odp

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6
Added preferences for engine.odf and engine.odp, and many others

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6
Added preferences for engine.odf and engine.odp, and many others

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6
Added preferences for engine.odf and engine.odp, and many others

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6
Added preferences for engine.odf and engine.odp, and many others

* issue with line endings or encoding

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6
Added preferences for engine.odf and engine.odp, and many others

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6
Added preferences for engine.odf and engine.odp, and many others
Fixed move to jetty 10

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6
Added preferences for engine.odf and engine.odp, and many others
Fixed move to jetty 10
Fixed memory in products
Added embedded java runtime to the products
Fixed build so that is uses a target platform

* How to import BIRT code into eclipse #628

Forbidden references should not be a warning but an error.
ReportLauncherUtils failed to compile with internal API
Jetty and Lucense upgrade
Removed shady references from the updatesite pom
Moved BIRT target to latest Eclipse
Moved debug.ui to Java11
Upgrade fop to 4.6 in chart.device.pdf
Removed version constrains in features
Added projectSet.psf for easy import
Moved to fop 2.6
Added preferences for engine.odf and engine.odp, and many others
Fixed move to jetty 10
Fixed memory in products
Fixed build so that it uses a target platform
Merged with new master
Moved to Tycho 2.4.0

* How to import BIRT code into eclipse #628

Fixed update site to add
* correct javax.servlet api
* jetty-continuation

and "Manage using" plugins instead of features

* How to import BIRT code into eclipse #628

Added additional requirements to the target
added a birt launch config

* How to import BIRT code into eclipse #628

Change maven-jar-plugin version
fixed target for batik
Switched to package deps for batik

* How to import BIRT code into eclipse #628

Fixed javadoc generation
Fixed pom warning

* How to import BIRT code into eclipse #628

Fixed build after merge with master
@wimjongman
Copy link
Contributor

Sorry about this Ed. I just pushed a big stabilization change that I did not realize you were not seeing.

@wimjongman
Copy link
Contributor

This one was fixed. Thanks all for pushing this. An important step forward.

Please use the new installer link and follow the instructions. The link is also available from the README.MD:

https://www.eclipse.org/setups/installer/?url=https://raw.githubusercontent.com/eclipse/birt/master/build/org.eclipse.birt.releng/BIRTConfiguration.setup&show=true

@patric-r
Copy link

patric-r commented Nov 5, 2021

When using this installer, I still get 21 java errors, "Access Restriction" (dom4j):

image

@ruspl-afed
Copy link
Contributor

Strange, I thougt it was fixed by the latest manifest adjustments
Let me see if I can rebase #678

@ruspl-afed
Copy link
Contributor

When using this installer, I still get 21 java errors, "Access Restriction" (dom4j):

I just merged #678 , please try to update sources from master branch without re-installing

@patric-r
Copy link

patric-r commented Nov 5, 2021

@ruspl-afed Yes, this fixed the problem! All java errors are now gone.
Congratulations and thanks!

However, I had several UI freezes (maybe because of the M2?).
And every time I restart the eclipse (clean shutdown) eclipse is going to rebuild BIRT. Why?

Next questions:

  • How to run the junit tests?
  • How to run the report designer?

@wimjongman
Copy link
Contributor

I also saw the UI freezes.

For the report designer to run you have to create a run configuration. There is already one run configuration available, you can run from there:

image

For the unit test to run you also have to create a run configuration. You can start finding the classes that are name AllTests and run these as JUnit plugins tests. This will create a run configuration that you will have to tweak in the Run Configuration dialog

image

image

@patric-r
Copy link

patric-r commented Nov 5, 2021

When running the "birtrun" configuration, I get:

image

Is this a known issue?

A click on "continue" starts the report designer, however.
In the console I see:

osgi> Nov 05, 2021 9:35:53 PM org.eclipse.birt.report.model.metadata.ExtensionLoader handleError
SEVERE: Message:Duplicate extension name when adding the extension [RotatedText] to the meta-data dictionary. Error code:DUPLICATE_EXTENSION_NAME 
(along with other SWT exceptions)

Has something changed regarding the project explorer in BIRT?
I used to create (report) projects and organize my rptdesign files there but it doesn't seem to work like this anymore.
I can create a Report Project, but it is not shown in the project explorer.

(will test junit later)

@wimjongman
Copy link
Contributor

wimjongman commented Nov 5, 2021

is this a known issue?

Yes.

In Eclipse you can have several starting points called applications. Currently, in the launch configuration, the DesignerApplication is used. You can play with that to launch BIRT in several 'modes'.

image

@patric-r
Copy link

patric-r commented Nov 6, 2021

Thanks. Have you seen my 2nd question?
Somethings seems to be really broken in the designer, neither the project explorer nor the navigator will show any created project.

@ruspl-afed
Copy link
Contributor

Somethings seems to be really broken in the designer, neither the project explorer nor the navigator will show any created project.

Please create another issue to discuss this. We will need steps to reproduce. Please also check if you can see the same problem when running from pre-built BIRT binaries.

@wimjongman
Copy link
Contributor

Thanks. Have you seen my 2nd question? Somethings seems to be really broken in the designer, neither the project explorer nor the navigator will show any created project.

That was an answer to your second question. Change the application to see BIRT in different outfits. The one you are looking at now does not have the project explorer. #628 (comment)

@patric-r
Copy link

patric-r commented Nov 6, 2021

@ruspl-afed: Which pre-built BIRT binaries do you mean? This one? https://download.eclipse.org/birt/downloads/drops/I-R1-4.8.0-201805221921/birt-report-designer-all-in-one-4.8.0-20180522-win32.win32.x86_64.zip

@wimjongman
Which "application" corresponds to the BIRT designer (= what happens when I execute the eclipse binary in above package)? I just assumed that it's the default (DesignerApplication) and then I would assume that it behaves in the same way

@ruspl-afed
Copy link
Contributor

@ruspl-afed: Which pre-built BIRT binaries do you mean? This one? https://download.eclipse.org/birt/downloads/drops/I-R1-4.8.0-201805221921/birt-report-designer-all-in-one-4.8.0-20180522-win32.win32.x86_64.zip

the binaries that you can produce with the local maven build.
please open another issue if you think that BIRT Designer has a bug, it seems to be not related with this ticket

@wimjongman
Copy link
Contributor

Patrick we can continue this discussion here: #692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants