Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Import=Package" directives to avoid compilation errors #678

Merged
merged 4 commits into from
Nov 5, 2021

Conversation

ruspl-afed
Copy link
Contributor

@ruspl-afed ruspl-afed commented Nov 1, 2021

Add
org.dom4j.tree;version="2.1.1"
to "org.eclipse.birt.build" bundle

Add
org.apache.fop.svg;version="2.6.0"
to "org.eclipse.birt.chart.device.pdf" bundle

Signed-off-by: Alexander Fedorov alexander.fedorov@arsysop.ru

Add
org.dom4j.tree;version="2.1.1"

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Add
 org.apache.fop.svg;version="2.6.0"

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
@ruspl-afed ruspl-afed changed the title Fix "Import=Package" directive for "org.eclipse.birt.build" Fix "Import=Package" directives to avoid compilation errors Nov 1, 2021
@ruspl-afed ruspl-afed mentioned this pull request Nov 1, 2021
Copy link
Contributor

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold. fop is currently embedded. When you run the build locally fop 2.6.0 will be automatically added. I have a separate PR aiming to fix this:

#675

@ruspl-afed
Copy link
Contributor Author

@wimjongman I removed the change regarding FOP, but it seems that we still need the change regarding org.dom4j.tree

@ruspl-afed ruspl-afed merged commit 6ce2fee into master Nov 5, 2021
@ruspl-afed ruspl-afed deleted the import_org_dom4j_tree branch November 18, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants