-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix and simplify workspace exposure strategies doc #1738
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Vala <mvala@redhat.com>
sparkoo
requested review from
yhontyk,
MichalMaler,
rkratky,
themr0c and
a team
as code owners
December 14, 2020 12:03
yhontyk
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Michal Vala <mvala@redhat.com>
…gateway single-host Signed-off-by: Michal Vala <mvala@redhat.com>
I've added network policy requirement warning for gateway single-host, fixing this issue eclipse-che/che#18453 |
skabashnyuk
approved these changes
Dec 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good in general.
modules/installation-guide/partials/con_workspace-exposure-strategies.adoc
Outdated
Show resolved
Hide resolved
...llation-guide/partials/proc_configuring-workspace-exposure-strategies-using-an-operator.adoc
Outdated
Show resolved
Hide resolved
...llation-guide/partials/proc_configuring-workspace-exposure-strategies-using-an-operator.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Michal Vala <mvala@redhat.com>
sleshchenko
reviewed
Dec 21, 2020
...llation-guide/partials/proc_configuring-workspace-exposure-strategies-using-an-operator.adoc
Show resolved
Hide resolved
Signed-off-by: Michal Vala <mvala@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Vala mvala@redhat.com
What does this PR do?
update workspace exposure strategies page, simplify it and focus more on simple installation steps
What issues does this PR fix or reference?
eclipse-che/che#18498
eclipse-che/che#18453
Specify the version of the product this PR applies to.
now
PR Checklist
As the author of this Pull Request I made sure that:
vale
has been run successfully against the PR branch