Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and simplify workspace exposure strategies doc #1738

Merged
merged 6 commits into from
Dec 21, 2020

Conversation

sparkoo
Copy link
Member

@sparkoo sparkoo commented Dec 14, 2020

Signed-off-by: Michal Vala mvala@redhat.com

Read our Contribution guide before submitting a PR.

What does this PR do?

update workspace exposure strategies page, simplify it and focus more on simple installation steps

What issues does this PR fix or reference?

eclipse-che/che#18498
eclipse-che/che#18453

Specify the version of the product this PR applies to.

now

PR Checklist

As the author of this Pull Request I made sure that:

  • vale has been run successfully against the PR branch
  • Link checker has been run successfully against the PR branch
  • Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
  • Changed article references are updated where they are used (or a redirect has been set up on the docs side):

Signed-off-by: Michal Vala <mvala@redhat.com>
@sparkoo sparkoo requested review from l0rd and removed request for a team December 14, 2020 12:03
@yhontyk yhontyk self-assigned this Dec 15, 2020
Copy link

@yhontyk yhontyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Michal Vala <mvala@redhat.com>
…gateway single-host

Signed-off-by: Michal Vala <mvala@redhat.com>
@sparkoo
Copy link
Member Author

sparkoo commented Dec 17, 2020

I've added network policy requirement warning for gateway single-host, fixing this issue eclipse-che/che#18453

Copy link
Contributor

@skabashnyuk skabashnyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in general.

Signed-off-by: Michal Vala <mvala@redhat.com>
@sparkoo sparkoo merged commit 4b4ea49 into eclipse-che:master Dec 21, 2020
@sparkoo sparkoo deleted the gh18498-singleHostDocs branch December 21, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants