This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
Update license to EPL 2.0 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sun Tan <sutan@redhat.com>
|
if you want to enforce the rule: https://github.com/eclipse/theia-generator-plugin/blob/master/tslint.json#L3-L7 |
|
I guess I can reuse this tslint.json file for all our project |
benoitf
reviewed
Aug 8, 2018
package.json
Outdated
| @@ -3,10 +3,14 @@ | |||
| "scripts": { | |||
| "prepare": "lerna run prepare", | |||
There was a problem hiding this comment.
maybe have tslint in prepare or build task ?
benoitf
reviewed
Aug 8, 2018
package.json
Outdated
| "rebuild:electron": "theia rebuild:electron" | ||
| "rebuild:electron": "theia rebuild:electron", | ||
| "tslint-fix": "tslint --fix --project github-extension", | ||
| "tslint": "tslint --fix --project github-extension" |
There was a problem hiding this comment.
in your example I don't see differences between tslint and tslint-fix
There was a problem hiding this comment.
done: removed --fix in the tslint one
Signed-off-by: Sun Tan <sutan@redhat.com>
benoitf
approved these changes
Aug 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclipse-che/che#10465