Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have Apache Camel extension supporting Java files too #10262

Closed
apupier opened this issue Jul 4, 2018 · 5 comments
Closed

Have Apache Camel extension supporting Java files too #10262

apupier opened this issue Jul 4, 2018 · 5 comments
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.

Comments

@apupier
Copy link
Contributor

apupier commented Jul 4, 2018

Description

Previously, the Apache Camel Language Server was providing help for xml files only; it is now providing completion and hover also for Java files.

Reproduction Steps

OS and version:

Diagnostics:
@apupier
Copy link
Contributor Author

apupier commented Jul 4, 2018 •
edited
Loading

identified point to modify:
https://github.com/eclipse/che/blob/09671a1b2b0ea1d9df5c537aa1c1cdb7ae47e981/plugins/plugin-camel/che-plugin-camel-server/src/main/java/org/eclipse/che/plugin/camel/server/languageserver/CamelLanguageServerConfig.java#L29
https://github.com/eclipse/che/blob/7a52c83f4dbf24f527986550181684f267934387/plugins/plugin-web/che-plugin-web-ext-web/src/main/java/org/eclipse/che/plugin/web/client/CamelLanguageDescriptionProvider.java#L20
https://github.com/eclipse/che/blob/7a52c83f4dbf24f527986550181684f267934387/plugins/plugin-web/che-plugin-web-ext-web/src/main/java/org/eclipse/che/plugin/web/client/CamelLanguageDescriptionProvider.java#L21

the first 2 ones seems not a problem to modify.
The last one, it seems that it is not a list, which MIME type should I use?

apupier added a commit to apupier/che that referenced this issue Jul 4, 2018
@apupier
Apache Camel Language LSP client compatible with Java files (eclipse-…
b39ba79 
…che#10262)

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier mentioned this issue Jul 4, 2018
Merged
apupier added a commit to apupier/che that referenced this issue Jul 5, 2018
@apupier
Apache Camel Language LSP client compatible with Java files (eclipse-…
4d491c0 
…che#10262)

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier
Copy link
Contributor Author

apupier commented Jul 6, 2018

is currently blocked by #6157

another solution would be to provide specific extension to completion of the current Java editor. Awaiting answer from Che team if it is possible and how much it would require.

@ghost ghost added the kind/question Questions that haven't been identified as being feature requests or bugs. label Jul 10, 2018
@apupier
Copy link
Contributor Author

apupier commented Jul 24, 2018

another solution would be to provide specific extension to completion of the current Java editor. Awaiting answer from Che team if it is possible and how much it would require.

the answer was that it is too complicated

apupier added a commit to apupier/che that referenced this issue Sep 21, 2018
@apupier
Apache Camel Language LSP client compatible with Java files (eclipse-…
745746b 
…che#10262)

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/che that referenced this issue Sep 21, 2018
@apupier
Apache Camel Language LSP client compatible with Java files (eclipse-…
8fe9f59 
…che#10262)

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/che that referenced this issue Oct 18, 2018
@apupier
Apache Camel Language LSP client compatible with Java files (eclipse-…
d512e26 
…che#10262)

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/che that referenced this issue Oct 19, 2018
@apupier
Apache Camel Language LSP client compatible with Java files (eclipse-…
20694ff 
…che#10262)

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/che that referenced this issue Oct 25, 2018
@apupier
Apache Camel Language LSP client compatible with Java files (eclipse-…
790270a 
…che#10262)

- remove language declaration for Camel, Camel is not a language type
but just a provider on top of other languages

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/che that referenced this issue Oct 26, 2018
@apupier
Apache Camel Language LSP client compatible with Java files (eclipse-…
ebba742 
…che#10262)

- remove language declaration for Camel, Camel is not a language type
but just a provider on top of other languages

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
dmytro-ndp pushed a commit that referenced this issue Nov 7, 2018
@apupier @dmytro-ndp
Apache Camel Language LSP client compatible with Java files (#10262) (#…
8089d3d 
…10264)

- remove language declaration for Camel, Camel is not a language type
but just a provider on top of other languages

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier
Copy link
Contributor Author

apupier commented Nov 8, 2018

Can someone with rights can add the 6.14.0 milestone to this issue please?

@apupier apupier closed this as completed Nov 8, 2018
@apupier
Copy link
Contributor Author

apupier commented Nov 8, 2018

and maybe change label from question to "enhancement" or something like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apupier