Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project-template API missing on Swagger #13792

Closed
sparkoo opened this issue Jul 8, 2019 · 5 comments
Closed

project-template API missing on Swagger #13792

sparkoo opened this issue Jul 8, 2019 · 5 comments
Assignees
@skabashnyuk
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.1.0

Comments

@sparkoo
Copy link
Member

sparkoo commented Jul 8, 2019

Description

/api/project-template is missing on /swagger. Service is defined here https://github.com/eclipse/che/blob/master/wsmaster/che-core-api-project-templates/src/main/java/org/eclipse/che/api/project/server/template/ProjectTemplateService.java
This is current list of documented apis:

devfile
factory
installer
logger
preferences
profile
ssh
stack
system
user
workspace

I believe this api should be included here. Maybe we're missing some more?

Reproduction Steps

deploy che and go to <che-url>/swagger . project-template is not there.

OS and version:
latest
Diagnostics:
@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Jul 8, 2019
@l0rd l0rd modified the milestones: 7.x, 7.1.0 Jul 8, 2019
@skabashnyuk skabashnyuk added the severity/P1 Has a major impact to usage or development of the system. label Jul 8, 2019
@skabashnyuk
Copy link
Contributor

we might need to revisit the whole ProjectTemplateService because of quite a lot of it functionality are Che6 oriented

@sparkoo
Copy link
Member Author

sparkoo commented Jul 15, 2019

maybe @ashumilova is using this API for her dashboard work

@sleshchenko
Copy link
Member

I believe project-template API should be deprecated and removed in flavor of Devfile Registry.
I believe there should be some issue for Dashboard not to use it anymore.

@ashumilova
Copy link
Contributor

We recently removed usage of this service on dashboard, so can be deprecated.

@skabashnyuk skabashnyuk mentioned this issue Jul 18, 2019
Closed
@sparkoo
Copy link
Member Author

sparkoo commented Jul 18, 2019

issue #13903 to remove the API was created. Closing this one.

@sparkoo sparkoo closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skabashnyuk skabashnyuk

Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.1.0
Development

No branches or pull requests
5 participants
@l0rd @sparkoo @ashumilova @skabashnyuk @sleshchenko