Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[omnisharp-plugin] Rename symbol doesn't work #13906

Closed
1 of 3 tasks
svor opened this issue Jul 18, 2019 · 2 comments
Closed
1 of 3 tasks

[omnisharp-plugin] Rename symbol doesn't work #13906

svor opened this issue Jul 18, 2019 · 2 comments
Labels
area/languages Issues related to Language extensions or plugins integration. kind/bug Outline of a bug - must adhere to the bug report template. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering.

Comments

@svor
Copy link
Contributor

svor commented Jul 18, 2019

Describe the bug

Rename symbol feature doesn't work in omnisharp-plugin. After trying to rename some symbol I see an error in the browser console:

Exception
Uncaught (in promise) Error: Internal Error - System.ArgumentNullException: Value cannot be null.
Parameter name: source
  at System.Linq.Enumerable.Select[TSource,TResult] (/dashboard/System.Collections.Generic.IEnumerable`1[T] source, System.Func`2[T,TResult] selector) [0x0000d] in <e32d3889c5e24db788c761b532f9d8a8>:0 
  at OmniSharp.LanguageServerProtocol.Handlers.RenameHandler+<>c.<Handle>b__5_1 (/dashboard/OmniSharp.Models.ModifiedFileResponse x) [0x00006] in <dd2ec58840214a8f8e50adfb6905d0fe>:0 
  at System.Linq.Enumerable.ToDictionary[TSource,TKey,TElement] (/dashboard/System.Collections.Generic.IEnumerable`1[T] source, System.Func`2[T,TResult] keySelector, System.Func`2[T,TResult] elementSelector, System.Collections.Generic.IEqualityComparer`1[T] comparer) [0x00095] in <e32d3889c5e24db788c761b532f9d8a8>:0 
  at System.Linq.Enumerable.ToDictionary[TSource,TKey,TElement] (/dashboard/System.Collections.Generic.IEnumerable`1[T] source, System.Func`2[T,TResult] keySelector, System.Func`2[T,TResult] elementSelector) [0x00000] in <e32d3889c5e24db788c761b532f9d8a8>:0 
  at OmniSharp.LanguageServerProtocol.Handlers.RenameHandler.Handle (/dashboard/OmniSharp.Extensions.LanguageServer.Protocol.Models.RenameParams request, System.Threading.CancellationToken token) [0x00109] in <dd2ec58840214a8f8e50adfb6905d0fe>:0 
  at OmniSharp.Extensions.LanguageServer.Server.Pipelines.ResolveCommandPipeline`2[TRequest,TResponse].Handle (/dashboard/TRequest request, System.Threading.CancellationToken cancellationToken, OmniSharp.Extensions.Embedded.MediatR.RequestHandlerDelegate`1[TResponse] next) [0x000e1] in <cdcdd2bceac34772b5fb2962192e6b77>:0 
  at OmniSharp.Extensions.LanguageServer.Server.LspRequestRouter.RouteRequest (/dashboard/OmniSharp.Extensions.JsonRpc.IHandlerDescriptor descriptor, OmniSharp.Extensions.JsonRpc.Server.Request request) [0x002e2] in <cdcdd2bceac34772b5fb2962192e6b77>:0

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

You can follow steps in the video: https://youtu.be/Zkm513MgBl8

@svor svor added kind/bug Outline of a bug - must adhere to the bug report template. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. area/languages Issues related to Language extensions or plugins integration. labels Jul 18, 2019
@svor
Copy link
Contributor Author

svor commented Aug 7, 2019

should be fixed by eclipse-che/che-plugin-registry#199

@svor
Copy link
Contributor Author

svor commented Nov 25, 2019

fixed by eclipse-che/che-plugin-registry#199

@svor svor closed this as completed Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/languages Issues related to Language extensions or plugins integration. kind/bug Outline of a bug - must adhere to the bug report template. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering.
Projects
None yet
Development

No branches or pull requests

1 participant