Replace the use of custom operator config map with a map inside the custom resource.

[davidfestal]

Is your enhancement related to a problem? Please describe.

Avoid the need to use the custom config map to override any customized Che server property (not driven by the CheCluster custom resource).
Instead we shoud have a way to override Che server properties directly inside the Custom resource.

Describe the solution you'd like

Have a map of values inside the CheCluster custom resource to allow overriding any Che server property. Something like:

 server:
    # server image used in Che deployment
    cheImage: ''
    # tag of an image used in Che deployment
    cheImageTag: 'nightly'
    ........ etc, etc ....
    overrideCheProperties:
    - name: CHE_SERVER_PROPERTY_1
       value: propValue1
    - name: CHE_SERVER_PROPERTY_2
       value: propValue2
  auth:
    .......etc, etc .....

[nickboldt]

Adding installation label as this is something we need for product.

[tomgeorge]

Is there a requirement that you cannot set things in overrideCheProperties that isn't a Che property? e.g. am I allowed to:

overrideCheProperties:
  - name: ARBITRARY_CHE_PROP_THAT_DOESNT_CONTROL_ANYTHING
    value: bar

[davidfestal]

No. We don't need validation, at least at first.

[amisevsk]

While I think some validation would be useful in case of typos, I don't know if it would be possible to actually implement that check, as Che will consume and env var that begins with CHE_ and convert it to a property. Having some sort of check here might require maintaining the list of "acceptable" overrides, in case they are later added to Che.

Up to David in the end, though.

Edit: responded while I was typing the message, disregard :)