Make Che Theia release script passing ShellCheck

[azatsarynnyy]

Is your task related to a problem? Please describe.

It would be great to make Che Theia release script passing ShellCheck.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

result of static analysis

$ shellcheck myscript
 
Line 69:
  read THEIA_VERSION < THEIA_VERSION
  ^-- SC2162: read without -r will mangle backslashes.
       ^-- SC2094: Make sure not to read and write the same file in the same pipeline.
                       ^-- SC2094: Make sure not to read and write the same file in the same pipeline.
 
Line 92:
      -e 's/THEIA_VERSION="..*"/THEIA_VERSION="'${THEIA_PATCHES_DIR}'"/' \
                                                ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
      -e 's/THEIA_VERSION="..*"/THEIA_VERSION="'"${THEIA_PATCHES_DIR}"'"/' \
 
Line 93:
      -e 's/THEIA_BRANCH="..*"/THEIA_BRANCH="'${THEIA_BRANCH}'"/' \
                                              ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
      -e 's/THEIA_BRANCH="..*"/THEIA_BRANCH="'"${THEIA_BRANCH}"'"/' \
 
Line 94:
      -e 's#THEIA_GIT_REFS="..*"#THEIA_GIT_REFS="'${THEIA_GIT_REFS}'"#' \
                                                  ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
      -e 's#THEIA_GIT_REFS="..*"#THEIA_GIT_REFS="'"${THEIA_GIT_REFS}"'"#' \
 
Line 95:
      -e 's/THEIA_DOCKER_IMAGE_VERSION=.*/THEIA_DOCKER_IMAGE_VERSION="'${VERSION}'"/'
>>                                                                     ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
      -e 's/THEIA_DOCKER_IMAGE_VERSION=.*/THEIA_DOCKER_IMAGE_VERSION="'"${VERSION}"'"/'
 
Line 102:
    sed -i ./${m}/package.json \
             ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
    sed -i ./"${m}"/package.json \
 
Line 103:
        -r -e 's/("version": )(".*")/\1"'$VERSION'"/' \
                                         ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
        -r -e 's/("version": )(".*")/\1"'"$VERSION"'"/' \
 
Line 104:
        -r -e '/plugin-packager/!s/("@theia\/..*": )(".*")/\1"'${THEIA_VERSION}'"/' \
>>                                                             ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
        -r -e '/plugin-packager/!s/("@theia\/..*": )(".*")/\1"'"${THEIA_VERSION}"'"/' \
 
Line 105:
        -r -e '/@eclipse-che\/api|@eclipse-che\/workspace-client|@eclipse-che\/workspace-telemetry-client/!s/("@eclipse-che\/..*": )(".*")/\1"'$VERSION'"/'
>>                                                                                                                                             ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
        -r -e '/@eclipse-che\/api|@eclipse-che\/workspace-client|@eclipse-che\/workspace-telemetry-client/!s/("@eclipse-che\/..*": )(".*")/\1"'"$VERSION"'"/'
 
Line 116:
            -e '/RUN git clone/s#$# \&\& cd ${HOME}/theia-source-code \&\& git checkout '${THEIA_COMMIT_SHA}'#'
               ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that.
>>                                                                                       ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
            -e '/RUN git clone/s#$# \&\& cd ${HOME}/theia-source-code \&\& git checkout '"${THEIA_COMMIT_SHA}"'#'
 
Line 120:
          -e '/RUN git clone/s#$# \&\& cd ${HOME} \&\& tar zcf ${HOME}/theia-source-code.tgz theia-source-code#'
             ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that.
 
Line 126:
          -r -e 's/( git checkout )(.*)/\1'${THEIA_COMMIT_SHA}'/'
                                           ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
          -r -e 's/( git checkout )(.*)/\1'"${THEIA_COMMIT_SHA}"'/'
 
Line 128:
          -r -e 's/( git checkout )(.*)( \&\& cd )/\1'${THEIA_COMMIT_SHA}'\3/'
                                                      ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: (apply this, apply all SC2086)
          -r -e 's/( git checkout )(.*)( \&\& cd )/\1'"${THEIA_COMMIT_SHA}"'\3/'

$