Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support devfile v2 factory link #18846

Closed
14 tasks done
l0rd opened this issue Jan 20, 2021 · 3 comments
Closed
14 tasks done

Support devfile v2 factory link #18846

l0rd opened this issue Jan 20, 2021 · 3 comments
Labels
area/factory/dashboard Issues related to factories frontend (che user dashboard side) area/factory/server Server side of factory implementation engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.

Comments

@l0rd
Copy link
Contributor

l0rd commented Jan 20, 2021

Is your enhancement related to a problem? Please describe.

If a github repository has a devfile.yaml that uses v2 of the devfile spec we are not able to start the workspace.

Describe the solution you'd like

Support factory link that points to a git repo of petclinic with a devfile 2.0 that has just maven and mysql components (no che-theia plugins). Theia and machine exec are implicitly added by Che. Subtasks:

Bugs:

@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. labels Jan 20, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 20, 2021
@l0rd l0rd added engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. area/factory/dashboard Issues related to factories frontend (che user dashboard side) area/factory/server Server side of factory implementation and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 20, 2021
@l0rd l0rd added this to the DevWorkspace Integration - STEP1 milestone Jan 25, 2021
@sleshchenko
Copy link
Member

It's implemented in someway, there are still some points which needs to be addressed on Dashboard side, and they can be tracked in #19147

@l0rd
Copy link
Contributor Author

l0rd commented Mar 3, 2021

I have actually reopened this epic and made it clear that #19147 is a subtask of it. I am doing it because in the milestone we only track issues at the epic level.

@l0rd l0rd reopened this Mar 3, 2021
@sleshchenko
Copy link
Member

The last PR is merged on dashboard side, the main workflow should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/factory/dashboard Issues related to factories frontend (che user dashboard side) area/factory/server Server side of factory implementation engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.
Projects
None yet
Development

No branches or pull requests

3 participants