Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Che Server should tell Dashboard if DevWorkspaces are supported or not #19160

Closed
Tracked by #18858
sleshchenko opened this issue Feb 25, 2021 · 4 comments
Closed
Tracked by #18858

Che Server should tell Dashboard if DevWorkspaces are supported or not #19160

sleshchenko opened this issue Feb 25, 2021 · 4 comments
Assignees
@sparkoo
Labels
area/che-server kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone
7.28

Comments

@sleshchenko
Copy link
Member

Is your task related to a problem? Please describe.

Dashboard don't know if DevWorkspaces should be fetched or not, and it depends on plafform + openshift oauth settings, since for milestone 1 we support only OpenShift + OpenShift OAuth enabled.

Describe the solution you'd like

Che Server returns something like

supportedWorkspaceTypes: cheWorkspace, devWorkspace

as part of workspace/settings.
^ devworkspace is not present for K8s or when Che is deployed without devworkspace: enabled in CheCluster CR.
@sleshchenko sleshchenko added kind/task Internal things, technical debt, and to-do tasks to be performed. area/che-server labels Feb 25, 2021
@skabashnyuk
Copy link
Contributor

What about property che.devworkspaces.enabled=false on che server side? We can expose it with /api/workspace/settings

@sparkoo sparkoo self-assigned this Mar 2, 2021
@sparkoo
Copy link
Member

sparkoo commented Mar 2, 2021

@xbaran4 will be working on this

@sleshchenko sleshchenko mentioned this issue Mar 2, 2021
Merged
@xbaran4 xbaran4 mentioned this issue Mar 3, 2021
Merged
9 tasks
@skabashnyuk skabashnyuk mentioned this issue Mar 3, 2021
Closed
12 tasks
@l0rd l0rd mentioned this issue Mar 3, 2021
Closed
1 task
@l0rd
Copy link
Contributor

l0rd commented Mar 3, 2021 •
edited
Loading

I have added this issue as a subtask of this epic. Removing it from the STEP1 milestone since it's not an epic and I am leaving only epics in the milestone.

@l0rd l0rd removed this from the DevWorkspace Integration - STEP1 milestone Mar 3, 2021
@skabashnyuk
Copy link
Contributor

merged in #19193

@skabashnyuk skabashnyuk added this to the 7.28 milestone Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sparkoo sparkoo

Labels
area/che-server kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.28
Development

No branches or pull requests
4 participants
@l0rd @sparkoo @skabashnyuk @sleshchenko