Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iframe of the editor in dashboard #20523

Closed
benoitf opened this issue Sep 23, 2021 · 2 comments
Closed

Remove iframe of the editor in dashboard #20523

benoitf opened this issue Sep 23, 2021 · 2 comments
Assignees
Labels
area/dashboard area/ux Issues related to User Experience Design kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@benoitf
Copy link
Contributor

benoitf commented Sep 23, 2021

Is your enhancement related to a problem? Please describe

When opening editors we have sidebar of the dashboard and the sidebar of the editor

Then, from UX, it's hard to know which sidebar do what.
Also we need to add some specific buttons (chevron in che-theia) inside the editors to collapse the dashboard sidebar

Describe the solution you'd like

Opening a editor (like clicking a getting started) should open a new window and not embed it inside an iframe

The workspaces running should be seen in a different view than with a sidebar inside dashboard

Describe alternatives you've considered

Rework iframe with some common UI to hide/show but it may still not look a correct UX/UI with the multiple sidebars

Additional context

No response

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. area/dashboard status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 23, 2021
@dmytro-ndp dmytro-ndp added severity/P2 Has a minor but important impact to the usage or development of the system. team/controller area/ux Issues related to User Experience Design and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 23, 2021
@wcho
Copy link

wcho commented Sep 24, 2021

I think it's also good for IntelliJ IDEs.

@benoitf
Copy link
Contributor Author

benoitf commented Oct 19, 2021

iFrame is removed when devWorkspace engine is enabled

@benoitf benoitf closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard area/ux Issues related to User Experience Design kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants