CHE-10808: Use master branch of Che-Theia-hosted-plugin-manager-extension #11039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
AndrienkoAleksandr
approved these changes
Sep 3, 2018
|
Tested on local docker infra and openshift.io |
evidolob
approved these changes
Sep 3, 2018
benoitf
added
status/code-review
benoitf
approved these changes
Sep 3, 2018
mmorhun
removed
the
status/code-review
dmytro-ndp
pushed a commit
that referenced
this pull request
Sep 4, 2018
…1039) Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before resolutions have been merged we used separate branch with specific npm packages versions to make che-theia-hosted-plugin-manager-extension works against latest Theia release.
Now, when resolutions are applied in our Theia image, we can use master branch of the extension without a need to patch the extension an each Theia release (unless API breaking changes introduced).
What issues does this PR fix or reference?
#10808