Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LSP4J to 0.5.0.M1 #11152

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Update LSP4J to 0.5.0.M1 #11152

merged 1 commit into from
Sep 11, 2018

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Sep 10, 2018 •
edited
Loading

What does this PR do?

Updates lsp4j to 0.5.0.M1to handle some selenium test failures related to lsp4j marshalling of Either<X, Y> types.

What issues does this PR fix or reference?

#10782

Companion PR: eclipse-che/che-parent#81

@tsmaeder
More changes due to update to 0.5.0.M1
f25066f 
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder tsmaeder added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. team/languages labels Sep 10, 2018
@tsmaeder tsmaeder changed the title More changes due to update to 0.5.0.M1 Update LSP4J to 0.5.0.M1 Sep 10, 2018
@benoitf benoitf added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Sep 10, 2018
@tsmaeder tsmaeder merged commit efd2c20 into eclipse-che:5730_java_ls_poc Sep 11, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svor svor svor approved these changes

@tolusha tolusha tolusha approved these changes

@dkuleshov dkuleshov Awaiting requested review from dkuleshov

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees
No one assigned
Labels
e2e-test/failure Issues that is related to a test failures reported by our CI platform and our QE. kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tsmaeder @svor @tolusha @benoitf