Stores logs of test workspaces which do not have RUNNING status #11233

dmytro-ndp · 2018-09-14T20:56:14Z

What does this PR do?

It improves test workspace logs storing:

stores logs of workspaces which do not have RUNNING status;
stores logs of injecting workspaces which did not start, packs such logs into the target/site/workspaces-logs/injecting_workspaces_which_did_not_start, and adds link into the 'Summary' section of failsafe report;
handle exception when verifying condition in WaitUtils.waitSuccessCondition();
not to wait 6 minutes if start of test workspace failed;
gets rid of AbstractTestWorkspaceProvider;
remakes WorkspaceTemplate to enum;
minor improvements.

What issues does this PR fix or reference?

#11200

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

…dition() Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

dmytro-ndp · 2018-09-14T20:56:26Z

ci-test

riuvshin · 2018-09-15T00:37:52Z

ci-test build report:
Build details
Test report
docker image: eclipseche/che-server:11233
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-09-15T06:28:28Z

ci-test

riuvshin · 2018-09-15T07:05:14Z

ci-test build report:
Build details
Test report
docker image: eclipseche/che-server:11233
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-09-15T07:51:33Z

ci-test

riuvshin · 2018-09-15T08:18:13Z

ci-test build report:
Build details
Test report
docker image: eclipseche/che-server:11233
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-09-15T08:44:24Z

ci-test

riuvshin · 2018-09-15T09:15:25Z

ci-test build report:
Build details
Test report
docker image: eclipseche/che-server:11233
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-09-15T09:22:58Z

ci-test

riuvshin · 2018-09-15T10:03:05Z

ci-test build report:
Build details
Test report
docker image: eclipseche/che-server:11233
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-09-15T10:06:43Z

ci-test

riuvshin · 2018-09-15T10:25:54Z

ci-test build report:
Build details
Test report
docker image: eclipseche/che-server:11233
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dmytro-ndp · 2018-09-15T11:12:10Z

ci-test

riuvshin · 2018-09-15T16:25:53Z

ci-test build report:
Build details
Test report
docker image: eclipseche/che-server:11233
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

riuvshin · 2018-09-16T11:05:13Z

ci-test

riuvshin · 2018-09-16T16:41:26Z

ci-test build report:
Build details
Test report
docker image: eclipseche/che-server:11233
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

…o enum Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Ohrimenko1988 · 2018-09-17T13:56:44Z

selenium/che-selenium-core/bin/webdriver.sh

-        docker rm $(docker ps -qa --filter="name=selenium_*")
+        echo "[TEST] Stopping and removing selenium docker containers..."
+        docker stop $(docker ps -qa --filter="name=selenium_*") > /dev/null
+        docker rm $(docker ps -qa --filter="name=selenium_*") > /dev/null


what about remove

docker stop $(docker ps -qa --filter="name=selenium_*") > /dev/null

and use

docker rm $(docker ps -qa --filter="name=selenium_*") > /dev/null

with "-f" flag:

docker rm -f $(docker ps -qa --filter="name=selenium_*") > /dev/null

Good catch! Thank you!

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

dmytro-ndp · 2018-09-17T15:27:23Z

ci-test

dmytro-ndp · 2018-09-17T15:51:59Z

@rhopp, @Katka92, @ScrewTSW: I need you feedback about commit 9cc5ad4

Some prerequisites: this PR was going to add new dependencies into AbstractTestWorkspaceProvider and this would affect RhCheTestWorkspaceProvider.

At the same time it looks like RhCheTestWorkspaceProvider doesn't really use workspace pool to get test workspace, so, IMHO, it would not make sense to have implementation of RhCheTestWorkspaceProvider.java::initializePool() there.

Given circumstances above, it was decided to get rid of AbstractTestWorkspaceProvider to decouple RhCheTestWorkspaceProvider from CheTestWorkspaceProvider specific staff.

To implement the changes into Rhche functional tests, it will be needed:

to remove RhCheTestWorkspaceProvider::initializePool() method;
to simplify RhCheTestWorkspaceProvider constructor;
to implement RhCheTestWorkspaceProvider::shutdown() method.

riuvshin · 2018-09-17T21:07:17Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11233
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

rhopp · 2018-09-18T11:32:46Z

@dmytro-ndp Thanks for letting us know! I think this change is good for both sides. looking into RhCheTestWorkspaceProvider we have lot of not needed stuff there and this change will simplify our code a lot. +1 for merging this PR. We will do changes on our side once we update the dependency to upstream che.

dmytro-ndp · 2018-09-18T12:41:14Z

@rhopp: thank you for feedback!

Dmytro Nochevnov added 6 commits September 14, 2018 19:27

Store logs of workspaces which donot have RUNNING status

5757b9c

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Handle exception when verifying condition in WaitUtils.waitSuccessCon…

ea7a556

…dition() Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Do not wait 6 minutes if start of test workspace failed

e5ed0ec

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Supress displaying removing selenium containers ids

c5f37b0

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Fix build warning

372a7cb

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Suppress warnings if it's impossible to get failed test workspace logs

d051d66

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

dmytro-ndp added kind/enhancement A feature request - must adhere to the feature request template. team/che-qe labels Sep 14, 2018

dmytro-ndp requested a review from Ohrimenko1988 September 14, 2018 20:56

dmytro-ndp requested a review from musienko-maxim as a code owner September 14, 2018 20:56

Merge remote-tracking branch 'origin/master' into che-11200

b105f8b

Get read of AbstractTestWorkspaceProvider; remake WorkspaceTemplate t…

9cc5ad4

…o enum Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

dmytro-ndp force-pushed the che-11200 branch from 772d50f to 9cc5ad4 Compare September 17, 2018 13:38

dmytro-ndp added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 17, 2018

Ohrimenko1988 reviewed Sep 17, 2018

View reviewed changes

Ohrimenko1988 approved these changes Sep 17, 2018

View reviewed changes

Dmytro Nochevnov added 2 commits September 17, 2018 17:57

Add missed files

f265056

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Use single command to stop and remove selenium docker containers

7631d3a

Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>

Merge remote-tracking branch 'origin/master' into che-11200

822f51f

dmytro-ndp merged commit 1bbdee3 into master Sep 18, 2018

dmytro-ndp deleted the che-11200 branch September 18, 2018 15:28

benoitf added this to the 6.12.0 milestone Sep 18, 2018

benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stores logs of test workspaces which do not have RUNNING status #11233

Stores logs of test workspaces which do not have RUNNING status #11233

dmytro-ndp commented Sep 14, 2018 •

edited

Loading

dmytro-ndp commented Sep 14, 2018

riuvshin commented Sep 15, 2018

dmytro-ndp commented Sep 15, 2018

riuvshin commented Sep 15, 2018

dmytro-ndp commented Sep 15, 2018

riuvshin commented Sep 15, 2018

dmytro-ndp commented Sep 15, 2018

riuvshin commented Sep 15, 2018

dmytro-ndp commented Sep 15, 2018

riuvshin commented Sep 15, 2018

dmytro-ndp commented Sep 15, 2018

riuvshin commented Sep 15, 2018

dmytro-ndp commented Sep 15, 2018

riuvshin commented Sep 15, 2018

riuvshin commented Sep 16, 2018

riuvshin commented Sep 16, 2018

Ohrimenko1988 Sep 17, 2018

dmytro-ndp Sep 17, 2018

dmytro-ndp commented Sep 17, 2018

dmytro-ndp commented Sep 17, 2018 •

edited

Loading

riuvshin commented Sep 17, 2018

rhopp commented Sep 18, 2018

dmytro-ndp commented Sep 18, 2018

Stores logs of test workspaces which do not have RUNNING status #11233

Stores logs of test workspaces which do not have RUNNING status #11233

Conversation

dmytro-ndp commented Sep 14, 2018 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

dmytro-ndp commented Sep 14, 2018

riuvshin commented Sep 15, 2018

dmytro-ndp commented Sep 15, 2018

riuvshin commented Sep 15, 2018

dmytro-ndp commented Sep 15, 2018

riuvshin commented Sep 15, 2018

dmytro-ndp commented Sep 15, 2018

riuvshin commented Sep 15, 2018

dmytro-ndp commented Sep 15, 2018

riuvshin commented Sep 15, 2018

dmytro-ndp commented Sep 15, 2018

riuvshin commented Sep 15, 2018

dmytro-ndp commented Sep 15, 2018

riuvshin commented Sep 15, 2018

riuvshin commented Sep 16, 2018

riuvshin commented Sep 16, 2018

Ohrimenko1988 Sep 17, 2018

Choose a reason for hiding this comment

dmytro-ndp Sep 17, 2018

Choose a reason for hiding this comment

dmytro-ndp commented Sep 17, 2018

dmytro-ndp commented Sep 17, 2018 • edited Loading

riuvshin commented Sep 17, 2018

rhopp commented Sep 18, 2018

dmytro-ndp commented Sep 18, 2018

dmytro-ndp commented Sep 14, 2018 •

edited

Loading

dmytro-ndp commented Sep 17, 2018 •

edited

Loading