Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not recognize file in workspace root as project #11264

Merged
merged 2 commits into from Sep 19, 2018
Merged

Do not recognize file in workspace root as project #11264

merged 2 commits into from Sep 19, 2018

Conversation

vzhukovs
Copy link
Contributor

What does this PR do?

This changes proposal improves behavior of file manager which works with files in workspace root. At first, additional check was added to avoid create project configuration when file is created in workspace root. And on the client side we don't show notification that project is created, when it's actually a file in workspace root.

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

What issues does this PR fix or reference?

#10586

Release Notes

N/A

Docs PR

N/A

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs vzhukovs added kind/bug Outline of a bug - must adhere to the bug report template. team/ide severity/P1 Has a major impact to usage or development of the system. labels Sep 18, 2018
@vzhukovs vzhukovs added this to the 6.12.0 milestone Sep 18, 2018
@vzhukovs vzhukovs self-assigned this Sep 18, 2018
@vzhukovs
Copy link
Contributor Author

ci-test

@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 18, 2018
@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11264
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs
Copy link
Contributor Author

ci-test

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11264
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@riuvshin
Copy link
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:11264
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@artaleks9
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/828/) doesn't show any regression against this Pull Request.

@vzhukovs vzhukovs merged commit 0ec9537 into master Sep 19, 2018
@vzhukovs vzhukovs deleted the che#10586 branch September 19, 2018 13:20
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
No open projects
IDE
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

7 participants