Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced ws.next sample stack with a Che7 preview stack #11543

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

l0rd
Copy link
Contributor

@l0rd l0rd commented Oct 8, 2018

What does this PR do?

Replace the HelloWorld workspace.next stacks with a Che 7 preview stack

What issues does this PR fix or reference?

#10644

Release Notes

Introduced Che 7 preview stack with sidecar plugins support and Theia as IDE

@l0rd l0rd requested review from benoitf and garagatyi October 8, 2018 21:43
@l0rd l0rd requested a review from ashumilova as a code owner October 8, 2018 21:43
y="217.98831"
style="font-style:normal;font-variant:normal;font-weight:bold;font-stretch:normal;font-size:192px;font-family:'DIN Alternate';-inkscape-font-specification:'DIN Alternate Bold';text-align:center;text-anchor:middle"
id="tspan194">7</tspan></tspan></text>
</svg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing eof

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
@l0rd l0rd merged commit 6fbcf65 into eclipse-che:master Oct 9, 2018
@l0rd l0rd deleted the che7-stacks branch October 9, 2018 08:39
@benoitf
Copy link
Contributor

benoitf commented Oct 9, 2018

@l0rd is there a backport planned on rh-che repository ?

@benoitf
Copy link
Contributor

benoitf commented Oct 9, 2018

for redhat-developer/rh-che#905

@l0rd
Copy link
Contributor Author

l0rd commented Oct 9, 2018

I am looking at it but it's currently not working because of #11547

@l0rd
Copy link
Contributor Author

l0rd commented Oct 9, 2018

Anyway it should be different because rh-che one should be ephemeral.

@benoitf benoitf added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Oct 9, 2018
@benoitf benoitf added this to the 6.13.0 milestone Oct 9, 2018
nickboldt pushed a commit to nickboldt/che that referenced this pull request Oct 9, 2018
…#11543)

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
nickboldt pushed a commit to nickboldt/che that referenced this pull request Oct 15, 2018
…#11543)

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants