[Selenium] Adapt the "TheiaBuildPluginTest" selenium test to changes in the top menu #11595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ohrimenko1988
added
kind/bug
musienko-maxim
approved these changes
Oct 11, 2018
dmytro-ndp
approved these changes
Oct 11, 2018
dmytro-ndp
reviewed
Oct 11, 2018
| * @param cssPropertyName name of the css properties which should be extracted | ||
| * @return value of the specified {@code cssPropertyName} | ||
| */ | ||
| public String waitAndGetCss(By elementLocator, String cssPropertyName) { |
There was a problem hiding this comment.
waitAndGetCss sounds too general. waitAndGetCssgetCssValue would be clear in this case, IMHO.
dmytro-ndp
reviewed
Oct 11, 2018
| * Waits visibility of element which specified by {@code elementLocator} and gets provided {@code | ||
| * cssPropertyName} from it. | ||
| * | ||
| * @param elementLocator locator of the investigated element |
There was a problem hiding this comment.
investigated > investigating
dmytro-ndp
reviewed
Oct 11, 2018
| * Waits until specified {@code cssPropertyName} in the element which defined by provided {@code | ||
| * elementLocator} is equals to {@code expectedValue}. | ||
| * | ||
| * @param elementLocator locator of the investigated element |
There was a problem hiding this comment.
investigated > investigating
dmytro-ndp
reviewed
Oct 11, 2018
| @@ -59,20 +62,82 @@ private TheiaTerminal( | |||
|
|
|||
| public interface Locators { | |||
| String TERMINAL_BODY_ID_TEMPLATE = "terminal-%s"; | |||
| String TERMINAL_TEXT_LAYER = "//canvas[@class='xterm-text-layer']"; | |||
| String TERMINAL_CURSOR_LAYER = "//canvas[@class='xterm-cursor-layer']"; | |||
| String TERMINAL_TEXT_LAYER = "(//canvas[@class='xterm-text-layer'])[%s]"; | |||
dmytro-ndp
reviewed
Oct 11, 2018
| String TERMINAL_TEXT_LAYER = "//canvas[@class='xterm-text-layer']"; | ||
| String TERMINAL_CURSOR_LAYER = "//canvas[@class='xterm-cursor-layer']"; | ||
| String TERMINAL_TEXT_LAYER = "(//canvas[@class='xterm-text-layer'])[%s]"; | ||
| String TERMINAL_CURSOR_LAYER = "(//canvas[@class='xterm-cursor-layer'])[%s]"; |
dmytro-ndp
reviewed
Oct 11, 2018
| } | ||
|
|
||
| private WebElement getTerminalTextLayer() { | ||
| return seleniumWebDriverHelper.waitVisibility(By.xpath(TERMINAL_TEXT_LAYER)); | ||
| private String getTerminalCursorLayer(int terminalIndex) { |
There was a problem hiding this comment.
getTerminalCursorLayer -> getTerminalCursorLayerXpath
dmytro-ndp
reviewed
Oct 11, 2018
| return seleniumWebDriverHelper.waitVisibility(By.xpath(terminalTextLayerXpath)); | ||
| } | ||
|
|
||
| public void waitTabSelected(String tabTitle) { |
There was a problem hiding this comment.
I see there are two patterns of method names includesTerminal. It looks redundant so as it is about Theia Terminal anyway.
dmytro-ndp
reviewed
Oct 11, 2018
| String WIDGET_BODY_XPATH = "//div[@class='monaco-quick-open-widget']"; | ||
| String SEARCH_FIELD_XPATH = WIDGET_BODY_XPATH + "//div[@class='quick-open-input']//input"; | ||
| String TREE_ROWS_XPATH = | ||
| WIDGET_BODY_XPATH |
There was a problem hiding this comment.
To improve readability I would move WIDGET_BODY_XPATH to the previous row.
dmytro-ndp
reviewed
Oct 11, 2018
| // for selection checking get "aria-selected" attribute. "true" if selected, "false" if not. | ||
| String WIDGET_BODY_XPATH = "//div[@class='monaco-quick-open-widget']"; | ||
| String SEARCH_FIELD_XPATH = WIDGET_BODY_XPATH + "//div[@class='quick-open-input']//input"; | ||
| String TREE_ROWS_XPATH = |
There was a problem hiding this comment.
What about renaming TREE_ROW > PROPOSAL?
dmytro-ndp
reviewed
Oct 11, 2018
| return seleniumWebDriverHelper.waitVisibilityOfAllElements(By.xpath(TREE_ROWS_XPATH)).size(); | ||
| } | ||
|
|
||
| public boolean isKeyBindingFieldExists(int proposalIndex) { |
There was a problem hiding this comment.
isKeyBindingFieldExists > isKeyBindingFieldExisted
dmytro-ndp
approved these changes
Oct 11, 2018
Ohrimenko1988
removed
the
status/code-review
nickboldt
pushed a commit
to nickboldt/che
that referenced
this pull request
Oct 15, 2018
nickboldt
pushed a commit
to nickboldt/che
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adapt the "TheiaBuildPluginTest" selenium test to changes in the top menu
What issues does this PR fix or reference?
Issue: #11545
Release Notes
Docs PR