[Selenium] Fix unexpected fails of "CheckBasicFunctionalityInCommandsExplorerTest", "CheckOnValidAndInvalidPackageNameTest" and "CheckShowHideHiddenFilesTest" selenium tests #11723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ohrimenko1988
added
kind/bug
Ohrimenko1988
requested review from
dmytro-ndp and
musienko-maxim
as code owners
artaleks9
approved these changes
Oct 24, 2018
dmytro-ndp
reviewed
Oct 24, 2018
| try { | ||
| waitItemIsSelected(path, REDRAW_UI_ELEMENTS_TIMEOUT_SEC); | ||
| return; | ||
| } catch (TimeoutException e) { | ||
| seleniumWebDriverHelper.hideContextMenu(); | ||
| waitContextMenuPopUpClosed(); | ||
| if (i == 2) { | ||
| throw e; | ||
| if (i >= 2) { |
dmytro-ndp
reviewed
Oct 24, 2018
| waitContextMenu(); | ||
|
|
||
| try { | ||
| waitItemIsSelected(path, REDRAW_UI_ELEMENTS_TIMEOUT_SEC); |
There was a problem hiding this comment.
The command waitItemIsSelected() has been added above.
Does it still make sense to check on item selection again after we obtained context menu?
There was a problem hiding this comment.
This block of code checks an error which described in the error message
dmytro-ndp
approved these changes
Oct 24, 2018
Ohrimenko1988
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix unexpected fails of "CheckBasicFunctionalityInCommandsExplorerTest", "CheckOnValidAndInvalidPackageNameTest" and "CheckShowHideHiddenFilesTest" selenium tests
What issues does this PR fix or reference?
Issue: #11716
Release Notes
Docs PR