Separation of components to allow overrides in codenvy #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| @Singleton | ||
| public class LinksInjector { | ||
|
|
There was a problem hiding this comment.
WorkspaceServiceLinksInjector?
|
ok |
akorneta
force-pushed
the
CODENVY-93
branch
3 times, most recently
from
cd7701f
to
f48828d
Compare
|
ok |
|
test-ci-build |
|
Can you rebase this PR. I've merged PR that is in conflict with yours |
| @@ -418,7 +418,7 @@ private Instance createInstance(String containerName, | |||
|
|
|||
| env = new ArrayList<>(devMachineEnvVariables); | |||
| env.add(DockerInstanceRuntimeInfo.CHE_WORKSPACE_ID + '=' + machine.getWorkspaceId()); | |||
| env.add(DockerInstanceRuntimeInfo.USER_TOKEN + '=' + EnvironmentContext.getCurrent().getSubject().getToken()); | |||
| env.add(DockerInstanceRuntimeInfo.USER_TOKEN + '=' + getUserToken(machine.getWorkspaceId())); | |||
There was a problem hiding this comment.
I think we should change USER_TOCKEN to API_TOKEN. Maybe not in this PR.
There was a problem hiding this comment.
it's not quite api token and I think this change will be made in the place with token restriction changes
|
I think that code coverage was decreased with this PR. Can you check and fix if needed? |
akorneta
force-pushed
the
CODENVY-93
branch
9 times, most recently
from
5419b49
to
99092a9
Compare
|
ok |
|
Build # 648 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/648/ to view the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@evoevodin, @skabashnyuk, @vparfonov review please
@benoitf, @ashumilova review this commit please