Modified the injection framework to use String for the workspace temp… #11792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late instead of the enum
ScrewTSW
requested review from
dmytro-ndp,
musienko-maxim and
Ohrimenko1988
as code owners
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
benoitf
added
the
status/code-review
dmytro-ndp
reviewed
Nov 5, 2018
| public String getTemplateFileName() { | ||
| return templateFileName; | ||
| } | ||
| public WorkspaceTemplate() {} |
There was a problem hiding this comment.
In constant class constructor is usually private.
dmytro-ndp
reviewed
Nov 5, 2018
| @@ -80,7 +79,7 @@ | |||
| }; | |||
|
|
|||
| /** It is Map[node-name, Pair[tab-name, line-number]] */ | |||
| private static final Map<String, Pair<String, Integer>> PROJECT_SYMBOL_EXPECTED_TEXT = | |||
| private static final ImmutableMap<String, Pair<String, Integer>> PROJECT_SYMBOL_EXPECTED_TEXT = | |||
dmytro-ndp
reviewed
Nov 5, 2018
| @@ -163,7 +163,7 @@ public void importProject( | |||
| format( | |||
| Resources.toString(getResource("projects/jdt-ls-project-files/project"), UTF_8), | |||
| projectName) | |||
| .getBytes()); | |||
| .getBytes(UTF_8)); | |||
Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
dmytro-ndp
approved these changes
Nov 5, 2018
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…late instead of the enum
What does this PR do?
Changes template referencing to String instead of locked down enum
What issues does this PR fix or reference?
https://app.zenhub.com/workspace/o/redhat-developer/che-functional-tests/issues/294
Release Notes
Docs PR