Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Devfile doc with default editor info #13029

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Update Devfile doc with default editor info #13029

merged 1 commit into from
Apr 1, 2019

Conversation

sleshchenko
Copy link
Member

What does this PR do?

This PR updates Devfile doc with default editor info.

What issues does this PR fix or reference?

#12835

Release Notes

N/A

Docs PR

N/A

@sleshchenko sleshchenko added kind/docs status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Apr 1, 2019
@sleshchenko sleshchenko self-assigned this Apr 1, 2019
@sleshchenko sleshchenko mentioned this pull request Apr 1, 2019
Merged
metlos
metlos approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please consider the proposed changes and fix the occasionally missing articles.

wsmaster/che-core-api-devfile/README.md Outdated Show resolved Hide resolved
wsmaster/che-core-api-devfile/README.md Outdated Show resolved Hide resolved
@riuvshin
Copy link
Contributor

riuvshin commented Apr 1, 2019

ci-build

@sleshchenko
Update Devfile doc with default editor info
cf41d94 
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
@sleshchenko
Copy link
Member Author

ci-build

@sleshchenko sleshchenko merged commit 797df4f into eclipse-che:master Apr 1, 2019
@sleshchenko sleshchenko deleted the defaultEditorDocs branch April 1, 2019 08:35
@benoitf benoitf added area/doc Issues related to documentation and removed kind/docs labels Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metlos metlos metlos approved these changes

@mshaposhnik mshaposhnik mshaposhnik approved these changes

Assignees

@sleshchenko sleshchenko

Labels
area/doc Issues related to documentation status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sleshchenko @riuvshin @metlos @mshaposhnik @benoitf