Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Stack service #14078

Merged
merged 3 commits into from
Sep 3, 2019
Merged

Remove Stack service #14078

merged 3 commits into from
Sep 3, 2019

Conversation

mkuznyetsov
Copy link
Contributor

@mkuznyetsov mkuznyetsov commented Jul 31, 2019 •
edited
Loading

Signed-off-by: Mykhailo Kuznietsov mkuznets@redhat.com

What does this PR do?

Remove Stack Service, as related code:

  • model
  • stack permissions
  • DAOs ( added DB migration script to drop stack tables )

What issues does this PR fix or reference?

#13459

Release Notes

Docs PR

@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 31, 2019
@mkuznyetsov
Copy link
Contributor Author

ci-test

@skabashnyuk skabashnyuk added this to the 7.1.0 milestone Aug 1, 2019
@che-bot
Copy link
Contributor

che-bot commented Aug 1, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14078
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@sleshchenko
Copy link
Member

sleshchenko commented Aug 1, 2019 •
edited
Loading

Please review every stack word that is left and make sure that it should not be removed.
Like che.predefined.stacks.reload_on_start configuration property, che-in-che.json, TracingTags.STACK_ID, TestStacksConstants

@mkuznyetsov
Copy link
Contributor Author

ci-test

2 similar comments
@dmytro-ndp
Copy link
Contributor

ci-test

@dmytro-ndp
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 1, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14078
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@dmytro-ndp
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 1, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14078
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@che-bot
Copy link
Contributor

che-bot commented Aug 1, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:14078
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@mkuznyetsov mkuznyetsov mentioned this pull request Aug 2, 2019
Closed
skabashnyuk
skabashnyuk reviewed Aug 2, 2019
View reviewed changes
Copy link
Contributor

@skabashnyuk skabashnyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general LGTM

...clipse/che/multiuser/permission/workspace/server/filters/PublicPermissionsRemoveChecker.java Show resolved Hide resolved
...iuser/sql-schema/src/main/resources/che-schema/7.0.0-RC5.0/0.1__remove_stack_permissions.sql Outdated Show resolved Hide resolved
...r/che-core-sql-schema/src/main/resources/che-schema/7.0.0-beta8.0-RC5.0/1__remove_stacks.sql Outdated Show resolved Hide resolved
...r/che-core-sql-schema/src/main/resources/che-schema/7.0.0-beta8.0-RC5.0/1__remove_stacks.sql Outdated Show resolved Hide resolved
@che-bot che-bot added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Aug 2, 2019
@skabashnyuk skabashnyuk force-pushed the che-13459 branch 5 times, most recently from 905f611 to 8a9ac17 Compare September 2, 2019 12:13
@eclipse-che eclipse-che deleted a comment from che-bot Sep 2, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 2, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 2, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 2, 2019
@eclipse-che eclipse-che deleted a comment from che-bot Sep 2, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14078

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@skabashnyuk
fixup! Remove Che6 Stack concept
6be78cb 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
sleshchenko
sleshchenko approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14078

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@skabashnyuk
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented Sep 2, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@skabashnyuk skabashnyuk merged commit 40ee503 into master Sep 3, 2019
@skabashnyuk skabashnyuk deleted the che-13459 branch September 3, 2019 06:00
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@mshaposhnik mshaposhnik mshaposhnik left review comments

@sleshchenko sleshchenko sleshchenko approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@metlos metlos Awaiting requested review from metlos

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

@dmytro-ndp dmytro-ndp Awaiting requested review from dmytro-ndp

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

@ibuziuk ibuziuk Awaiting requested review from ibuziuk

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
7 participants
@mkuznyetsov @che-bot @sleshchenko @dmytro-ndp @l0rd @skabashnyuk @mshaposhnik