Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commands to download latest release version of chectl in E2E happy path tests PR job #14182

Merged
merged 3 commits into from Aug 9, 2019
Merged

Fix commands to download latest release version of chectl in E2E happy path tests PR job #14182

merged 3 commits into from Aug 9, 2019

Conversation

dmytro-ndp
Copy link
Contributor

@dmytro-ndp dmytro-ndp commented Aug 9, 2019 •
edited

What does this PR do?

It switches Jenkinsfile of E2E Happy path tests to use chectl of 20190802065601 version while there is no chectl-linux binary of latest release:

+ wget --no-verbose https://github.com/che-incubator/chectl/releases/latest/download/chectl-linux -O /home/codenvy/workspace/Single-Che-PR-check-E2E-Happy-path-tests-against-k8s-on-codenvy-slave9/chectl

https://github.com/che-incubator/chectl/releases/download/20190809114555/chectl-linux:
ERROR 404: Not Found.

@dmytro-ndp
Switch to 20190802065601 chectl version in E2E happy path tests
7625433 
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@dmytro-ndp dmytro-ndp requested a review from rhopp August 9, 2019 12:46
@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 9, 2019
sleshchenko
sleshchenko reviewed Aug 9, 2019
View reviewed changes
e2e/jenkins/crw-ci/pr-check/k8s/Jenkinsfile Outdated
@@ -38,7 +38,8 @@ pipeline {
steps {
script {
sh """
wget --no-verbose https://github.com/che-incubator/chectl/releases/latest/download/chectl-linux \\
# wget --no-verbose https://github.com/che-incubator/chectl/releases/latest/download/chectl-linux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it quick fix and you plan to rework it to use latest chectl?
there is some archive for linux[1] but I'm not sure how it's supposed to be used.
@benoitf you know more, looks like README.md contains outdated info

[1] https://github.com/che-incubator/chectl/releases/download/20190809124036/chectl-v0.0.20190809-next.3bed253-linux-x64.tar.gz

Copy link
Contributor Author

@dmytro-ndp dmytro-ndp Aug 9, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quick fix of PR check pipeline job.

@dmytro-ndp
Use https://www.eclipse.org/che/chectl/ script to get chectl binary
9898a7a 
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@eclipse-che eclipse-che deleted a comment from che-bot Aug 9, 2019
rhopp
rhopp approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@rhopp rhopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the easiest solution for now.
In future we might implement something which don't require usage of /usr/local/bin.

Something like:

curl -sL https://che-incubator.github.io/chectl/download-link/stable-linux-x64

cat stable-linux-64 |xargs curl -sL

tar -xvf
PATH=$(pwd)/chectl/bin:$PATH

(I haven't tried this, but something like this should imo work)

@dmytro-ndp
Copy link
Contributor Author

@rhopp : yes, and as an alternative, there could installation path option be implemented in install script #14184

@dmytro-ndp
Copy link
Contributor Author

pipeline-ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 9, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@dmytro-ndp
Work around 'bash: /dev/fd/63: No such file or directory' error
36c9561 
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@dmytro-ndp dmytro-ndp force-pushed the fix-chectl-address-in-jenkinsfile branch from b52c3e2 to 36c9561 Compare August 9, 2019 21:57
@eclipse-che eclipse-che deleted a comment from che-bot Aug 9, 2019
@dmytro-ndp
Copy link
Contributor Author

pipeline-ci-test

@che-bot
Copy link
Contributor

che-bot commented Aug 9, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14182

@dmytro-ndp dmytro-ndp changed the title Switch to 20190802065601 chectl version in E2E happy path tests Fix commands to download latest release version of chectl in E2E happy path tests PR job Aug 9, 2019
@dmytro-ndp
Copy link
Contributor Author

ci-build

@che-bot che-bot added the kind/bug Outline of a bug - must adhere to the bug report template. label Aug 9, 2019
@dmytro-ndp
Copy link
Contributor Author

ci-build

@dmytro-ndp dmytro-ndp merged commit dd6ee43 into master Aug 9, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Aug 9, 2019
@dmytro-ndp dmytro-ndp deleted the fix-chectl-address-in-jenkinsfile branch August 9, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleshchenko sleshchenko sleshchenko left review comments

@rhopp rhopp rhopp approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmytro-ndp @che-bot @rhopp @sleshchenko