Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt test after updating Monaco editor #14523

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Adapt test after updating Monaco editor #14523

merged 2 commits into from
Sep 12, 2019

Conversation

musienko-maxim
Copy link
Contributor

After merge Theia PR:
Monaco editor was updated. It reflected on che e2e test. We got some changes in the DOM and new issue: #14520

What does this PR do?

This PR adapt the tests to to the new changes. The code navigation part was skipped as temporary solution. We are going to implement workaround: #14522

What issues does this PR fix or reference?

#14512

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Sep 12, 2019
Signed-off-by: musienko maksym <mmusiien@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 12, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14523

@che-bot
Copy link
Contributor

che-bot commented Sep 12, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@che-bot
Copy link
Contributor

che-bot commented Sep 12, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • "che-server" docker image: maxura/che-server:14523

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
@musienko-maxim musienko-maxim merged commit 501e2e5 into master Sep 12, 2019
@musienko-maxim musienko-maxim deleted the che#14512 branch September 12, 2019 14:55
@che-bot che-bot added this to the 7.2.0 milestone Sep 12, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 12, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 12, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 12, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Sep 12, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants