Che Java Test Runner Plugin #2157

Mirage20 · 2016-08-17T18:13:56Z

What does this PR do?

This pull request implements Java unit test runner plugin for che, which enables users to easily run Java unit tests within the IDE and view/navigate the test results.

Features

Supports common test frameworks : JUnit 3.x, JUnit 4.x, TestNG
Supports Maven project types.
Main menu and context menu items for running test cases.
Able to run per class and per project tests. (Or per suite if TestNG with testng.xml suite)
UI notification about the progress and result.
UI (Information view) for show the test results.
Easy navigation for failing results. (Tree navigation for classes and methods)
Able to view stack trace and assertion difference.
Able to jump to the failing class and the line from the test result view.
Provide extensible framework for adding new test engines.

Tests written?

Yes

Documentation

Plugin Documentration: https://docs.google.com/document/d/1BclPyGRjgExWwgxqBmb-CoHuRMxKsW8yRVVa3gP7pYI/edit?usp=sharing

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

…ting-ide Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

…me, method and line numbers to the dto Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

…GUI, added goto failing class to the GUI Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

…m navigation pannel Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

…d user experiance Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

…rces Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

…le structure Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

skabashnyuk

Please respond to all my comments.

skabashnyuk · 2016-10-15T10:49:10Z

...-java-test-runner/che-java-testing-classpath/che-java-testing-classpath-maven-server/pom.xml

+    <parent>
+        <artifactId>che-java-testing-classpath</artifactId>
+        <groupId>org.eclipse.che.plugin</groupId>
+        <version>4.7.0-RC2-SNAPSHOT</version>


sync with version in master

skabashnyuk · 2016-10-15T10:50:06Z

plugins/plugin-java-test-runner/che-java-testing-classpath/pom.xml

+    <parent>
+        <artifactId>che-plugin-java-test-runner-parent</artifactId>
+        <groupId>org.eclipse.che.plugin</groupId>
+        <version>4.7.0-RC2-SNAPSHOT</version>


sync with version in master

skabashnyuk · 2016-10-15T10:50:13Z

plugins/plugin-java-test-runner/che-java-testing-core/che-java-testing-core-ide/pom.xml

+    <parent>
+        <artifactId>che-java-testing-core</artifactId>
+        <groupId>org.eclipse.che.plugin</groupId>
+        <version>4.7.0-RC2-SNAPSHOT</version>


sync with version in master

skabashnyuk · 2016-10-15T10:51:29Z

...ipse/che/ide/ext/java/testing/core/client/view/navigation/factory/TestResultNodeFactory.java

+import org.eclipse.che.ide.ext.java.testing.core.client.view.navigation.nodes.TestResultMethodNode;
+import org.eclipse.che.ide.ext.java.testing.core.shared.TestResult;
+/**
+ *


skabashnyuk · 2016-10-15T10:51:50Z

.../eclipse/che/ide/ext/java/testing/core/client/view/navigation/nodes/TestResultClassNode.java

+import javax.validation.constraints.NotNull;
+import java.util.List;
+/**
+ *


skabashnyuk · 2016-10-15T10:55:44Z

plugins/plugin-java-test-runner/che-java-testing-junit/pom.xml

+    <parent>
+        <artifactId>che-plugin-java-test-runner-parent</artifactId>
+        <groupId>org.eclipse.che.plugin</groupId>
+        <version>4.7.0-RC2-SNAPSHOT</version>


sync with version in master

skabashnyuk · 2016-10-15T10:55:50Z

plugins/plugin-java-test-runner/che-java-testing-testng/che-java-testing-testng-ide/pom.xml

+    <parent>
+        <artifactId>che-java-testing-testng</artifactId>
+        <groupId>org.eclipse.che.plugin</groupId>
+        <version>4.7.0-RC2-SNAPSHOT</version>


sync with version in master

skabashnyuk · 2016-10-15T10:56:28Z

plugins/plugin-java-test-runner/che-java-testing-testng/che-java-testing-testng-server/pom.xml

+    <parent>
+        <artifactId>che-java-testing-testng</artifactId>
+        <groupId>org.eclipse.che.plugin</groupId>
+        <version>4.7.0-RC2-SNAPSHOT</version>


sync with version in master

skabashnyuk · 2016-10-15T10:56:45Z

plugins/plugin-java-test-runner/che-java-testing-testng/pom.xml

+    <parent>
+        <artifactId>che-plugin-java-test-runner-parent</artifactId>
+        <groupId>org.eclipse.che.plugin</groupId>
+        <version>4.7.0-RC2-SNAPSHOT</version>


sync with version in master

skabashnyuk · 2016-10-15T10:56:51Z

plugins/plugin-java-test-runner/pom.xml

+    <parent>
+        <artifactId>che-plugin-parent</artifactId>
+        <groupId>org.eclipse.che.plugin</groupId>
+        <version>4.7.0-RC2-SNAPSHOT</version>


sync with version in master

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

…ner plugin Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

vparfonov · 2016-10-26T19:29:30Z

...src/main/java/org/eclipse/che/ide/ext/java/testing/junit/client/action/RunAllTestAction.java

+import java.util.Map;
+
+import static org.eclipse.che.ide.api.notification.StatusNotification.DisplayMode.FLOAT_MODE;
+import static org.eclipse.che.ide.api.notification.StatusNotification.Status.*;


avoid "*" imports

removed wildcard imports

vparfonov · 2016-10-26T19:30:29Z

...java/org/eclipse/che/ide/ext/java/testing/junit/client/action/RunClassContextTestAction.java

+import java.util.Map;
+
+import static org.eclipse.che.ide.api.notification.StatusNotification.DisplayMode.FLOAT_MODE;
+import static org.eclipse.che.ide.api.notification.StatusNotification.Status.*;


avoid "*" imports

removed wildcard imports

vparfonov · 2016-10-26T19:35:12Z

...rc/main/java/org/eclipse/che/ide/ext/java/testing/testng/client/action/RunAllTestAction.java

+    }
+
+    @Override
+    protected void updateProjectAction(ActionEvent e) {


do we need empty method here?

vparfonov · 2016-10-26T19:37:45Z

.../main/java/org/eclipse/che/ide/ext/java/testing/testng/client/action/RunClassTestAction.java

+import java.util.Map;
+
+import static org.eclipse.che.ide.api.notification.StatusNotification.DisplayMode.FLOAT_MODE;
+import static org.eclipse.che.ide.api.notification.StatusNotification.Status.*;


avoid "*" imports

removed wildcard imports

vparfonov · 2016-10-26T19:38:40Z

...rc/main/java/org/eclipse/che/ide/ext/java/testing/testng/client/action/RunTestXMLAction.java

+    }
+
+    @Override
+    protected void updateProjectAction(ActionEvent e) {


do we need empty method here?

vparfonov · 2016-10-26T19:43:20Z

@Mirage20 please answer on our comments, we want to make QA circle with your branch and merge it

thanks for your work

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

skabashnyuk

Please answer to my comments.

skabashnyuk · 2016-10-31T07:43:11Z

...-server/src/main/java/org/eclipse/che/ide/ext/java/testing/junit/server/JUnitTestRunner.java

+
+/**
+ * JUnit implementation for the test runner service.
+ *


Please declare all parameters that this class can accept in execute method.

Updated the javadoc with parameters.

skabashnyuk · 2016-10-31T07:43:20Z

...ng-server/src/main/java/org/eclipse/che/ide/ext/java/testing/testng/server/TestNGRunner.java

+
+/**
+ * TestNG implementation for the test runner service.
+ *


Please declare all parameters that this class can accept in execute method.

Updated the javadoc with parameters.

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

skabashnyuk · 2016-11-09T08:04:07Z

@Mirage20 I think we good to go to the next step.
We will deploy your PR in one of our acceptance server and will run our selenium tests.
If we would not see any regressions we will accept this pr.

vparfonov · 2016-11-16T22:55:21Z

@Mirage20 Hello again I fix few error in your code and merge with master. Create new one branch in che for merge your Test Plugin to Che. So please review changes here #3095 you can merge my branch to your.
FYI: we started QA circle on your PR

* added java test runner plugin to the che project Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

vparfonov · 2016-11-22T13:47:43Z

merged here #3095

kaloyan-raev · 2016-11-23T08:23:23Z

Is this implementation tightly coupled to Java?

Can we use it for PHPUnit - a PHP unit testing framework, which from design point of view is similar to the Java unit testing frameworks?

vparfonov · 2016-11-23T15:15:56Z

For now it coupled to Java and it's pretty new plugin form community not much functionality covered. But your question really good, will be good provide some API for testing framework like we did with debugger

* added java test runner plugin to the che project Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Mirage20 added 30 commits June 5, 2016 13:41

added java test runner plugin to the che project

7b8e0fb

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

updated for che version 4.3.0-RC2-SNAPSHOT

a33403c

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

renamed che-plugin-java-ext-testing-client to che-plugin-java-ext-tes…

3fd0bfe

…ting-ide Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

added factory pattern to get the test runners, added failing class na…

69e2fa2

…me, method and line numbers to the dto Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Merge branch 'master' into che-java-test-runner

9c2ae2b

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

fixed maven process hangon on testing

23b0318

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

added basic GUI, added run class and run all classes feature for the …

e8840a6

…GUI, added goto failing class to the GUI Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Merge branch 'master' into che-java-test-runner

8b47d87

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

improved test runner GUI by removing the dialogs and added as a botto…

ffd6ae5

…m navigation pannel Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Merge branch 'master' into che-java-test-runner

da168b6

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

added test menu icon and context menu item for testing

fd7db3d

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Merge branch 'master' into che-java-test-runner

a0991f8

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

added icons for menu items and result tree,improved user interface an…

3ba1fc9

…d user experiance Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

removed workspaceID parameter from the test service client

69574d4

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Merge branch 'master' into che-java-test-runner

8d5f074

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

added localization for the java test runner plugin, re-arranged resou…

654d655

…rces Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Merge branch 'master' into che-java-test-runner

ad5adb1

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

changed java test runner module names

fe226b6

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

removed junit server implimentation from the testing core

d055cf8

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

added maven classpath generation for the test runner, refactored modu…

b674f66

…le structure Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

added testFramework as a get parameter

533dde0

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

seperated junit specific shared dto from the test core

4b6bace

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

seperated junit specific client code from the test core

1b2c6b9

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

updated localization constants in junit test runner.

bc8c7c2

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

formatted license header

b9379dd

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

added javadoc comments

81b5231

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

updated test runner to che 4.5, added JUnit 3.x support

33511ba

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

changed junit test runner package structure

9ad1dec

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

improved exception handling in che test runner core

3020082

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

added basic TestNG support to the test runner

fe18303

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

skabashnyuk requested changes Oct 15, 2016

View reviewed changes

Mirage20 added 3 commits October 15, 2016 21:31

Updated with 'master' version

27d1f5e

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

updated java-test-runner plugin to version 5.0.0-M6

056c258

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

added missing javadoc comments in the java test runner plugin

5dd6282

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Mirage20 force-pushed the che-java-test-runner-updated branch from 71f97de to 5dd6282 Compare October 15, 2016 17:09

Mirage20 added 3 commits October 15, 2016 23:09

added file seperator when generating test class paths

f06525b

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

updated project paths with maven projects attributes in java test run…

ced09b3

…ner plugin Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

removed unwanted spaces

6d60d0b

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

vparfonov removed the sprint/current label Oct 17, 2016

vparfonov reviewed Oct 26, 2016

View reviewed changes

removed wildcard imports in test runner plugin

2fab4e2

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

skabashnyuk requested changes Oct 31, 2016

View reviewed changes

updated javadocs in test runner plugin

ea968f5

Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

skabashnyuk approved these changes Nov 9, 2016

View reviewed changes

vparfonov approved these changes Nov 9, 2016

View reviewed changes

vparfonov added the sprint/current label Nov 11, 2016

vparfonov mentioned this pull request Nov 16, 2016

CHE-2157: preparation for merge https://github.com/eclipse/che/pull/2157 #3095

Merged

vparfonov pushed a commit that referenced this pull request Nov 22, 2016

CHE-2157: preparation for merge #2157 (#3095)

4bad844

* added java test runner plugin to the che project Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

vparfonov closed this Nov 22, 2016

vparfonov mentioned this pull request Nov 22, 2016

CHE-2157: Che Java Test Runner Plugin codenvy/codenvy#1202

Merged

vparfonov added this to the 5.0.0-M8 milestone Nov 23, 2016

vparfonov removed status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. sprint/current labels Nov 25, 2016

JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017

CHE-2157: preparation for merge eclipse-che#2157 (eclipse-che#3095)

1bdf6cc

* added java test runner plugin to the che project Signed-off-by: Mirage Abeysekara <mirage.12@cse.mrt.ac.lk>

Che Java Test Runner Plugin #2157

Che Java Test Runner Plugin #2157

Conversation

Mirage20 commented Aug 17, 2016

What does this PR do?

Features

Tests written?

Documentation

skabashnyuk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vparfonov commented Oct 26, 2016

skabashnyuk left a comment

Choose a reason for hiding this comment

skabashnyuk Oct 31, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skabashnyuk Oct 31, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skabashnyuk commented Nov 9, 2016

vparfonov commented Nov 16, 2016

vparfonov commented Nov 22, 2016

kaloyan-raev commented Nov 23, 2016

vparfonov commented Nov 23, 2016 • edited Loading

skabashnyuk Oct 31, 2016 •

edited

Loading

skabashnyuk Oct 31, 2016 •

edited

Loading

vparfonov commented Nov 23, 2016 •

edited

Loading