Fixes #2592: Filter code completion proposals from language server #2658
Conversation
…e server Implements filtering based on the existing FuzzyMatches used for the GoToSymbolAction. Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
|
Can one of the admins verify this patch? |
|
@evidolob - maybe not tied to this PR, but should we think about shrinking the height of the selection box if the number of filtered entries is less than the visible space? This could make some of the logic challenging as depending upon zoom level of the browser, the number of entries varies. |
| } | ||
|
|
||
| .codeassistant-highlight { | ||
| color: completionPopupItemHighlightTextColor; | ||
| } |
There was a problem hiding this comment.
@TylerJewell Sorry, but I don't understand your request. This part is formatted like the rest of the file.
There was a problem hiding this comment.
All files need to have an empty line at the end.
There was a problem hiding this comment.
Now I get it. I will add one.
benoitf
added
kind/enhancement
|
ci-build |
|
Build # 641 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/641/ to view the results. |
|
thanks, nice job |
…e server (eclipse-che#2658) * Fixes eclipse-che#2592: Filter code completion proposals from language server Implements filtering based on the existing FuzzyMatches used for the GoToSymbolAction. Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com> * Add empty line at end of file.
benoitf
removed
the
status/code-review
What does this PR do?
Implements filtering based on the existing FuzzyMatches used for the
GoToSymbolAction.
What issues does this PR fix or reference?
Previous behavior
The list of completion proposal was not filtered based on the user input. The issue is especially visible on language servers (like those for JSON and PHP) which do not execute such filtering on the server side and leave it to the client. See #2592 for details.
New behavior
The list of completion proposal is filtered using a fuzzy matching strategy. Look at the below animation:
PR type
Minor change checklist
Signed-off-by: Kaloyan Raev kaloyan.r@zend.com