-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CODENVY-931: add snapshot creating state to workspace status #2747
Conversation
if (this.workspaceStatuses.indexOf(message.eventType) >= 0) { | ||
this.getWorkspaceById(workspaceId).status = message.eventType; | ||
} else if (message.eventType === 'SNAPSHOT_CREATED') { | ||
this.getWorkspaceById(workspaceId).status = 'RUNNING'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status is RUNNING ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, workspace snapshot can be created for running workspace only, so it's really running. But we artificially introduce - SNAPSHOT_CREATING - to display it as status, though real status is still RUNNING. And we get back to it on SNAPSHOT_CREATED event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I see thx
if (this.workspaceStatuses.indexOf(message.eventType) >= 0) { | ||
this.getWorkspaceById(workspaceId).status = message.eventType; | ||
} else if (message.eventType === 'SNAPSHOT_CREATED') { | ||
this.getWorkspaceById(workspaceId).status = 'RUNNING'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I see thx
Build # 674 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/674/ to view the results. |
Missing labels |
Signed-off-by: Ann Shumilova <ashumilova@codenvy.com>
a421cd5
to
e9d63c8
Compare
CODENVY-931: add snapshot creating state to workspace status
What does this PR do?
Adds snapshot creating state to workspace status indicator.
What issues does this PR fix or reference?
codenvy/codenvy#931
Previous behavior
Snapshot creating was shown as stopped workspace.
New behavior
Orange circle for snapshot in progress is displayed.
Signed-off-by: Ann Shumilova ashumilova@codenvy.com