Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix position for toolbar buttons #3097

Merged
merged 1 commit into from
Nov 17, 2016
Merged

fix position for toolbar buttons #3097

merged 1 commit into from
Nov 17, 2016

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Nov 17, 2016

What does this PR do?

Fix position for toolbar buttons. Improve disable state for save stack button.

Signed-off-by: Oleksii Orel oorel@codenvy.com

selection_030
selection_031

Signed-off-by: Oleksii Orel <oorel@codenvy.com>
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be great for new PRs on Ui changes to have screenshot before and screenshot after (or just after)

@olexii4 olexii4 merged commit 7345fce into master Nov 17, 2016
@olexii4 olexii4 deleted the fix_toolbar_buttons branch November 17, 2016 10:25
@benoitf
Copy link
Contributor

benoitf commented Nov 17, 2016

thx Oleksii for the screenshots

@olexii4 olexii4 added this to the 5.0.0-M8 milestone Nov 17, 2016
@codenvy-ci
Copy link

JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants