Start eclipse/che-server docker image as root by default #3297
Conversation
benoitf
added
kind/enhancement
|
What I need to rebuild to test? |
|
@skabashnyuk here are the steps: and then launch cli |
| @@ -121,10 +121,6 @@ init() { | |||
| export CHE_WORKSPACE_STORAGE_CREATE_FOLDERS=false | |||
| fi | |||
|
|
|||
| # Ensure that the user "user" has permissions for CHE_HOME and CHE_DATA | |||
| sudo chown -R user:user ${CHE_HOME} | |||
| sudo chown -R user:user ${CHE_DATA} | |||
There was a problem hiding this comment.
@benoitf I think that these may be needed for the workspaces (that are still run as user user)
There was a problem hiding this comment.
@l0rd issue is that user 'user' may have another uid so it doesn't work as well.
There was a problem hiding this comment.
@l0rd also I think workspaces only need access to /projects which is done there
https://github.com/eclipse/che/blob/5fbaf3d9ac45344b5596742b27d9335652d3d0ca/wsmaster/che-core-api-agent/src/main/resources/agents/scripts/org.eclipse.che.ws-agent.script.sh#L38
|
What about agents and other software that you want to install outside of /projects? |
|
agents need to have sudo access so they have root access to do what they want. ? |
|
yep - got it. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1236/ |
|
@skabashnyuk do you have tested ? |
benoitf
removed
the
status/code-review
What does this PR do?
Start eclipse/che-server docker image as root by default
What issues does this PR fix or reference?
#3276
Previous behavior
User user had to be in docker group but with a specific gid which is not always the case
New behavior
Start che server as root user by default
Use root user by default to start che-server
another PR is about specifying how to run che-server with a custom uid/gid
#3265
Change-Id: Ib2635dc9b8364b92caa768dc8e4de0603cbcf14f
Signed-off-by: Florent BENOIT fbenoit@codenvy.com