Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add images of docs/ folder using git-lfs #3443

Merged
merged 1 commit into from
Dec 21, 2016
Merged

Add images of docs/ folder using git-lfs #3443

merged 1 commit into from
Dec 21, 2016

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Dec 20, 2016 •
edited
Loading

Add back images of docs but now using git-lfs
Images will be stored on github lfs storage (reduce git repository size)

https://help.github.com/articles/versioning-large-files/

image

@benoitf
Add images of docs/ folder using git-lfs
e9551d8 
Change-Id: I9cf39b4711252a8df0a36c319ffd1089735f1265
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
@skabashnyuk skabashnyuk mentioned this pull request Dec 20, 2016
Merged
JamesDrummond
JamesDrummond approved these changes Dec 20, 2016
View reviewed changes
Copy link
Contributor

@JamesDrummond JamesDrummond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imported your branch no problem with codenvy IDE git menu.

@JamesDrummond JamesDrummond mentioned this pull request Dec 20, 2016
Closed
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 20, 2016
@benoitf benoitf added this to the 5.0.0-M9 milestone Dec 20, 2016
@benoitf benoitf added kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current labels Dec 20, 2016
@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1400/

@benoitf benoitf merged commit 7405c66 into master Dec 21, 2016
@benoitf benoitf deleted the add-docs-images branch December 21, 2016 07:24
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 21, 2016
@benoitf benoitf self-assigned this Dec 21, 2016
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
@benoitf
Add images of docs/ folder using git-lfs (eclipse-che#3443)
8470b4f 
Change-Id: I9cf39b4711252a8df0a36c319ffd1089735f1265
Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@garagatyi garagatyi garagatyi approved these changes

@JamesDrummond JamesDrummond JamesDrummond approved these changes

@TylerJewell TylerJewell Awaiting requested review from TylerJewell

Assignees

@benoitf benoitf

Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@benoitf @codenvy-ci @skabashnyuk @garagatyi @JamesDrummond