IDEX-3913: Implement stack api #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| @PostConstruct | ||
| public void start() { |
There was a problem hiding this comment.
Use lock for @PostConstruct and @PredDestroy methods as well
AndrienkoAleksandr
force-pushed
the
IDEX-3913
branch
from
847cad4
to
d719636
Compare
| <artifactId>che-core-ide-stacks</artifactId> | ||
| <packaging>jar</packaging> | ||
| <name>Che Core :: IDE :: STACKS</name> | ||
| </project> |
AndrienkoAleksandr
force-pushed
the
IDEX-3913
branch
from
d719636
to
8c70828
Compare
| @@ -0,0 +1,710 @@ | |||
| [ | |||
There was a problem hiding this comment.
why these stacks are part of ide core module ? as it's more linked to the core/platform than IDE
There was a problem hiding this comment.
AndrienkoAleksandr
force-pushed
the
IDEX-3913
branch
from
8c70828
to
98362d1
Compare
| { | ||
| "name": "default", | ||
| "limits": { | ||
| "memory": 1000 |
There was a problem hiding this comment.
This field now called "ram"
There was a problem hiding this comment.
Ok, I'll fix it.
AndrienkoAleksandr
force-pushed
the
IDEX-3913
branch
2 times, most recently
from
0b9a0e2
to
a4d32ca
Compare
|
+1 |
|
ok |
|
Generally it looks okay |
Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
AndrienkoAleksandr
force-pushed
the
IDEX-3913
branch
from
a4d32ca
to
fa7eb17
Compare
AndrienkoAleksandr
added a commit
that referenced
this pull request
Feb 16, 2016
IDEX-3913: Implement stack api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_1 Upvote_ Signed-off-by: Aleksandr Andrienko aandrienko@codenvy.com