Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more consistent assembly #36

Merged
merged 4 commits into from
Aug 31, 2015
Merged

Make more consistent assembly #36

merged 4 commits into from
Aug 31, 2015

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Aug 28, 2015

No description provided.

@skabashnyuk
Copy link
Contributor

What is the general idea. What does it change?

@benoitf
Copy link
Contributor Author

benoitf commented Aug 28, 2015

general idea is what is described in all the JIRA issues

  • simpler and consistent with open source product binaries (like if you go on Apache Tomcat, there is a zip file, a tgz file and folder is contained in the compressed file)
  • Avoid any post-compilation steps

@skabashnyuk
Copy link
Contributor

Do you know what is it?

[INFO]
[INFO] --- maven-assembly-plugin:2.5.3:single (make-assembly) @ assembly-sdk ---
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o 'org.eclipse.che.sdk:recipes'

[INFO] Copying files to /home/sj/java/src/codenvy/che/assembly-sdk/target/assembly-sdk-3.12.2-SNAPSHOT
[WARNING] Assembly file: /home/sj/java/src/codenvy/che/assembly-sdk/target/assembly-sdk-3.12.2-SNAPSHOT is not a regular file (it may be a directory). It cannot be attached to the project build for installation or deployment.
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o 'org.eclipse.che.sdk:recipes'

[INFO] Building zip: /home/sj/java/src/codenvy/che/assembly-sdk/target/assembly-sdk-3.12.2-SNAPSHOT.zip
[WARNING] The following patterns were never triggered in this artifact inclusion filter:
o 'org.eclipse.che.sdk:recipes'

[INFO] Building tar: /home/sj/java/src/codenvy/che/assembly-sdk/target/assembly-sdk-3.12.2-SNAPSHOT.tar.gz
[WARNING] Entry: assembly-sdk-3.12.2-SNAPSHOT/sdk-resources/src/main/java/org/eclipse/che/api/deploy/ApiServletModule.java longer than 100 characters.
[WARNING] Resulting tar file can only be processed successfully by GNU compatible tar commands
[INFO]

@benoitf
Copy link
Contributor Author

benoitf commented Aug 28, 2015

about recipes, checking

about tar, assembly plugin should include

 <configuration>
          <!-- Use GNU Tar -->
            <tarLongFileMode>gnu</tarLongFileMode>
          </configuration>

@benoitf
Copy link
Contributor Author

benoitf commented Aug 28, 2015

About recipes:
0961cbc#diff-3aaa092b1bc397d08c6095a9f50e8784L51
my yesterday commit has been reverted so recipes are no longer added

@benoitf
Copy link
Contributor Author

benoitf commented Aug 28, 2015

so I've fixed the merge issue here
c2f2abf

@benoitf
Copy link
Contributor Author

benoitf commented Aug 28, 2015

and about GNU warning
codenvy-legacy/che-parent#2

@skabashnyuk
Copy link
Contributor

ok.
Plz squash this changes before commit.

@benoitf
Copy link
Contributor Author

benoitf commented Aug 31, 2015

It's 4 different issues so it will become less readable with a squash

@benoitf benoitf merged commit 8c5074f into master Aug 31, 2015
@benoitf benoitf deleted the fix-assembly-che branch September 11, 2015 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants