Change the way how exceptions are handled when a ws-agent pings Che s… #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public void start() { | ||
| try { | ||
| final HttpJsonResponse pingResponse = httpJsonRequestFactory.fromUrl(apiEndpoint) | ||
| .setMethod(HttpMethod.GET) |
There was a problem hiding this comment.
Formatting is wrong. Please fix indentation
…case a ws agent cannot ping Che server for whatever reason. Signed-off-by: Eugene Ivantsov <eivantsov@codenvy.com>
ghost
force-pushed
the
fixed_api_endpoint_checker_logic
branch
from
48bb24a
to
ef05a9a
Compare
Signed-off-by: Alexander Garagatyi <agaragatyi@codenvy.com>
garagatyi
force-pushed
the
fixed_api_endpoint_checker_logic
branch
from
a8f22b3
to
1a86ec3
Compare
|
ok @vparfonov @garagatyi ? |
|
LGTM |
ghost
pushed a commit
that referenced
this pull request
Feb 17, 2016
Change the way how exceptions are handled when a ws-agent pings Che s…
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by a user - #319
Correctly handle exceptions and print out helpful diagnostic info in case a ws agent cannot ping Che server for whatever reason.
Signed-off-by: Eugene Ivantsov eivantsov@codenvy.com