Chefile handling of inner Dockerfile content #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I9f6c1dacbef86e2345af5d3c867620658becf8fb Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
Change-Id: Id5ed7cd33c1fe2907dda15918fd2ead158ab544b Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
benoitf
added
kind/bug
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1753/ |
TylerJewell
reviewed
Jan 24, 2017
| static keepWorkspaceRawStrings(value : string) : string { | ||
| return value.replace(/^(workspace.)(.*)=\`(.*)$/gm, '$1$2=String.raw`$3'); | ||
| } | ||
|
|
||
| } |
TylerJewell
approved these changes
Jan 24, 2017
…r comments correctly 1. Multiline content is escaped by default while it shouldn’t for Dockerfile content. Users may add “String.raw” but it’s not obvious so add it automatically 2. Handle # comments correctly Change-Id: Icafb2e790f83b4a62c0c4d29edf2be08cff1a96f Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
|
@TylerJewell fixed |
benoitf
removed
the
status/code-review
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1760/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #3704 by handling recipe content as a raw content and handle # for comments correctly
Multiline content is escaped by default while it shouldn’t for Dockerfile content.
Users may add “String.raw” but it’s not obvious so add it automatically
Handle # comments correctly
What issues does this PR fix or reference?
Fix #3704
Changelog and Release Note Information
Changelog
Handle dockerfile content in Chefile as raw string
Release Notes:
bug only
Docs Pull Request
no doc, bug fixing.