Limit CPU consumption by build docker image tasks #3893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Morhun <mmorhun@codenvy.com>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1766/ |
garagatyi
approved these changes
Jan 25, 2017
skabashnyuk
approved these changes
Jan 25, 2017
slemeur
added
the
kind/enhancement
slemeur
changed the title
|
@mmorhun - can you briefly explain if this helps customer and how it changes things for them? |
|
@bmicklea this issue applys CPU comsumption limits which was added by @garagatyi in this issue (except |
|
Great, added Changelog |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…n-by-docker-build CODENVY-1393: Limit CPU consumption by build docker image tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds limits on CPU consumption by build docker image task.
Adds a few tests.
What issues does this PR fix or reference?
codenvy/codenvy#1393
Changelog
Adds CPU limits to Docker build process executions so they don't starve an entire node.
Release Notes
** CPU Limiting for Docker Builds **
We've added a CPU limiter for executions of the Docker build process. Build operations can be very CPU-intensive and this limit ensures that they don't starve workspaces on the same node. You can set other types of resource limits for Che through properties in the
che.envfile.