Implement OpenShift pull, tag, and inspectImage #3956

amisevsk · 2017-01-31T07:13:11Z

Implement OpenShiftConnector pull, tag, and inspectImage through
ImageStreams. Makes changes to how containers are created.

Currently snapshots do not work, as commit and push methods are not
implemented (these are being worked on by @ibuziuk currently). Additionally,
pulling a stack from a private repository is not yet implemented.

The changes necessitate reworking OpenShiftConnector#createContainer()
to accomodate using ImageStreams instead of the underlying Docker implementation.

What does this PR do?

Adds implementations of pull, tag and inspectImage to OpenShiftConnector.

Additionally, this PR refactors the helper methods used in OpenShiftConnector to be
static, as they store no state and serve as utility methods. This makes OpenShiftConnector
somewhat cleaner.

Changelog

Implement OpenShiftConnector pull, tag, and inspectImage through
ImageStreams. Makes changes to how containers are created.

Docs Pull Request

https://github.com/eclipse/che-docs/issues/76

amisevsk · 2017-01-31T07:13:27Z

@ibuziuk @l0rd Please take a look when you have time.

codenvy-ci · 2017-01-31T07:15:00Z

Can one of the admins verify this patch?

benoitf · 2017-01-31T07:50:39Z

ci-build

codenvy-ci · 2017-01-31T08:46:12Z

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1819/

ibuziuk · 2017-01-31T09:00:06Z

...enshift-client/src/main/java/org/eclipse/che/plugin/openshift/client/OpenShiftConnector.java

+                                .getItems();
+
+            if (pods.size() < 1) {
+                throw new DockerException(String.format("Pod with deployment name %s not found",


@amisevsk might be more relevant to throw OpenShiftException now ?

One reason I didn't do this is that OpenShiftException is unchecked, and so it wouldn't be obvious that it could be thrown when using the methods. DockerException is an IOException.

With the latest commit, I've changed OpenShiftException to a subclass of IOException (like DockerException) and used it instead of DockerException.

ibuziuk · 2017-01-31T09:01:06Z

...lient/src/main/java/org/eclipse/che/plugin/openshift/client/kubernetes/KubernetesEnvVar.java

@@ -23,17 +23,17 @@
 /**
 * Provides API for managing Kubernetes {@link EnvVar}
 */
-public class KubernetesEnvVar {
+public final class KubernetesEnvVar {


@amisevsk for all final util classes I would also add private constructor

benoitf · 2017-01-31T13:17:22Z

@amisevsk you need to rebase your branch (there is a conflict)

ibuziuk · 2017-02-01T16:35:04Z

@amisevsk works just fine in most cases. However, I can reproduce pretty often the following error:
Unable to start workspace agent. Error when trying to start the workspace agent: Start of environment 'default' failed. Error: Image eclipse/ubuntu_jdk8:latest not found.
It is not reproducible while debugging and I guess it might be coupled that 5 seconds delays might be not enough for Image metadata to be obtained / pulled. WDYT ?

amisevsk · 2017-02-01T16:43:13Z

@ibuziuk sounds like a likely issue; I'll look into it.

amisevsk · 2017-02-01T18:47:40Z

@ibuziuk I've been able to reproduce the issue occasionally, but yeah, it doesn't happen when debugging or if the image has already been pulled.

It's happening because OpenShift is taking longer than 5 seconds to get metadata about the docker repository. I've increased the max wait time to 10 seconds, which will hopefully fix the issue. However, since it doesn't always occur, I can't be sure. If it does occur again, could you manually check that the data is pulled (Builds -> Images -> <image-name> in OpenShift console)? That would confirm that it's just a timeout issue.

OpenShift doesn't seem to offer a way to monitor the progress here, so we are kind of stuck waiting. The (now 20 second) maximum wait time between pull and tag shouldn't have much of an impact in practical use, since the image stream tags are created quickly once the image has been pulled.

l0rd · 2017-02-07T10:40:37Z

...enshift-client/src/main/java/org/eclipse/che/plugin/openshift/client/OpenShiftConnector.java

+                                                 .inNamespace(openShiftCheProjectName)
+                                                 .withName(imageStreamName)
+                                                 .get();
+        String registryAddress = imageStream.getStatus()


I would test if imageStream is not null before using it

l0rd · 2017-02-07T10:42:37Z

...enshift-client/src/main/java/org/eclipse/che/plugin/openshift/client/OpenShiftConnector.java

+        String imageStreamTagPullSpec = imageStreamTag.getMetadata().getName();
+
+        // Next we need to get the address of the registry where the ImageStreamTag is stored
+        String imageStreamName = imageStreamTagPullSpec.split(":")[0];


It is safer to check if variable imageStreamTagPullSpec contains ":" before calling split(). You should do the same for all calls to the split() method.

Agreed. I didn't do it before because OpenShift should complain that an ImageStreamTag name does not contain ":", but I'm not sure. Fixed.

l0rd · 2017-02-07T10:52:18Z

...enshift-client/src/main/java/org/eclipse/che/plugin/openshift/client/OpenShiftConnector.java

@@ -408,6 +434,194 @@ public Network inspectNetwork(InspectNetworkParams params) throws IOException {
                            .withEnableIPv6(false);
    }

+    @Override
+    public void pull(final PullParams params, final ProgressMonitor progressMonitor) throws IOException {
+        // This method does not cause the relevant image to actually be pulled to the local


You may use this comment for pull() javadoc

Good idea -- done.

l0rd · 2017-02-07T21:57:25Z

ci-build

Implement OpenShiftConnector pull, tag, and inspectImage through ImageStreams. Makes changes to how containers are created. Currently snapshots do not work, as commit and push methods are not implemented. Additionally, pulling a stack from a private repository is not supported. Signed-off-by: Angel Misevski <amisevsk@redhat.com>

amisevsk · 2017-02-08T17:30:56Z

I've squashed and rebased onto master. Additionally, I've added a minor fix for tests broken by commit 41541e0.

ibuziuk reviewed Jan 31, 2017

View reviewed changes

amisevsk force-pushed the openshift-connector-images-rebase branch from a75cbf3 to 307d5b3 Compare January 31, 2017 13:35

l0rd reviewed Feb 7, 2017

View reviewed changes

l0rd added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 7, 2017

l0rd approved these changes Feb 7, 2017

View reviewed changes

l0rd added this to the 5.3.0 milestone Feb 7, 2017

amisevsk force-pushed the openshift-connector-images-rebase branch from 39299c0 to 3bad564 Compare February 8, 2017 17:29

l0rd merged commit b6a056f into eclipse-che:master Feb 9, 2017

l0rd removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 9, 2017

JamesDrummond mentioned this pull request Feb 17, 2017

5.3.0 Milestone Overview #4030

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement OpenShift pull, tag, and inspectImage #3956

Implement OpenShift pull, tag, and inspectImage #3956

amisevsk commented Jan 31, 2017 •

edited by JamesDrummond

Loading

amisevsk commented Jan 31, 2017

codenvy-ci commented Jan 31, 2017

benoitf commented Jan 31, 2017

codenvy-ci commented Jan 31, 2017

ibuziuk Jan 31, 2017

amisevsk Jan 31, 2017

amisevsk Feb 7, 2017

ibuziuk Jan 31, 2017

amisevsk Jan 31, 2017

benoitf commented Jan 31, 2017

ibuziuk commented Feb 1, 2017

amisevsk commented Feb 1, 2017

amisevsk commented Feb 1, 2017

l0rd Feb 7, 2017

amisevsk Feb 7, 2017

l0rd Feb 7, 2017

amisevsk Feb 7, 2017

l0rd Feb 7, 2017

amisevsk Feb 7, 2017

l0rd commented Feb 7, 2017

amisevsk commented Feb 8, 2017

Implement OpenShift pull, tag, and inspectImage #3956

Implement OpenShift pull, tag, and inspectImage #3956

Conversation

amisevsk commented Jan 31, 2017 • edited by JamesDrummond Loading

What does this PR do?

Changelog

Docs Pull Request

amisevsk commented Jan 31, 2017

codenvy-ci commented Jan 31, 2017

benoitf commented Jan 31, 2017

codenvy-ci commented Jan 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benoitf commented Jan 31, 2017

ibuziuk commented Feb 1, 2017

amisevsk commented Feb 1, 2017

amisevsk commented Feb 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

l0rd commented Feb 7, 2017

amisevsk commented Feb 8, 2017

amisevsk commented Jan 31, 2017 •

edited by JamesDrummond

Loading