[cli] graceful stop command

[benoitf]

What does this PR do?

Introduce graceful stop command for cli
by default, stopcommand is performing a graceful stop : stop all services then stop and remove containers
using --forcethe graceful stop is not done : we stop containers and remove containers

auth can be used with --user and --password

What issues does this PR fix or reference?

#3886

Changelog and Release Note Information

Changelog

Add graceful stop (disable with --force) in CLI

Release Notes:
We have introduced a way to perform a graceful stop of Che. Previously, Che server stops would be timeout based, meaning that if any workspaces were running when the Che server was stopped, they would continue to run. We have introduced a graceful stop that will initiate shutdown of all workspaces before initiating a shutdown of the server. If workspaces are configured to auto-snapshot during stop, then graceful stop will wait for all workspaces to be snapped before stopping the server.

The default CLI stop command now performs a graceful stop. It stops all services then stops and remove containers. You can optionally add a --force option to stop and remove containers without waiting for workspaces to stop. For authenticated servers like Codenvy, authentication can be provided by --user and --password.

default graceful stop: docker run ... eclipse/che stop
skip graceful stop: docker run ... eclipse/che stop --force
use auth : docker run ... eclipse/che stop --user <myemail> --password <my-secret>

Docs Pull Request

eclipse-che/che-docs#117
codenvy/docs#61

[TylerJewell]

Since this is a new feature then the release notes to have a deeper explanation and example.

[benoitf]

@TylerJewell ok I've updated release notes section

[riuvshin]

what will happen if auth is not provided ?
like in first example docker run ... eclipse/che stop

[benoitf]

@riuvshin if auth is required it will tell you that you can't perform operation as you need authentication

[riuvshin]

so maybe we have to add --force here https://github.com/eclipse/che/blob/master/dockerfiles/base/scripts/base/commands/cmd_destroy.sh#L40 because in case of destroy who will care about auth

[benoitf]

@riuvshin yes good catch

[benoitf]

@riuvshin what about cmd_stop in cmd_upgrade ?

[riuvshin]

in cmd_upgrade we must do graceful stop, so I think we have to change cmd_upgrade to ask user do manually stop with auth before cmd_upgrade same as we do for cmd_backup https://github.com/eclipse/che/blob/master/dockerfiles/base/scripts/base/commands/cmd_backup.sh#L29

@TylerJewell @benoitf wdyt guys?

[benoitf]

@riuvshin yes looks like the proper solution for me. So the user can decide if he performs a stop right now, delay it and do it with force or not

[TylerJewell]

Yes, I think that makes sense to me, too.

[benoitf]

ok, I've added the changes

[TylerJewell]

I updated the release notes comment.

[codenvy-ci]

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1828/