update docker hub url in cli tests #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riuvshin
added
the
kind/bug
TylerJewell
suggested changes
Feb 16, 2017
benoitf
approved these changes
Feb 16, 2017
|
@TylerJewell @benoitf yeah I was wondering why when guys trying skip tests it still fail I believe that this one in library was not skipped |
benoitf
reviewed
Feb 16, 2017
| @@ -74,56 +74,6 @@ server_is_booted() { | |||
| fi | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
AFAIk this method is called from https://github.com/eclipse/che/blob/b446d114250d6e4e7b23e57a045929d9b3f20a6d/dockerfiles/base/scripts/base/startup_01_init.sh#L283
There was a problem hiding this comment.
should I remove this line ?
There was a problem hiding this comment.
@TylerJewell should I remove that line? I don;t know how to detect where that method was used
This reverts commit a4f3771.
|
we agreed to clean up duplicate things after release |
benoitf
approved these changes
Feb 16, 2017
TylerJewell
approved these changes
Feb 16, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/1988/ |
9 tasks
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* update docker hub url in cli tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
in cli tests we checked old url for docker hub
dockerhub.comdue to some reasons that url is down really often so we switch to new urlChangelog
update docker hub url in cli tests