[cli/che-ip] Add search algorithm for host ip with fedora enp* network interfaces #4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4020 Change-Id: I6b65eba02eaab76260d33ffb323fe7413d5ee162 Signed-off-by: Florent BENOIT <fbenoit@codenvy.com>
benoitf
added
kind/bug
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2035/ |
ghost
approved these changes
Feb 22, 2017
TylerJewell
approved these changes
Feb 22, 2017
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fedora uses network interfaces enp* instead of common "eth0" interface
It allows to get primary network interface instead of docker0 network interface
Add tests for non-regression
What issues does this PR fix or reference?
#4020
Changelog
Add search algorithm for host ip with fedora enp* network interfaces
Release Notes
N/A bug
Docs PR
N/A bug