Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add angular-aria direct version #4365

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Add angular-aria direct version #4365

merged 1 commit into from
Mar 9, 2017

Conversation

ashumilova
Copy link
Contributor

Signed-off-by: Ann Shumilova ashumilova@codenvy.com

What does this PR do?

Fixes build failure due to updating of transitive dependency.
The dependency has CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=10670

Changelog

Add version for angular-aria dependency in dashboard.

Release Notes

N/A

Docs PR

N/A

Signed-off-by: Ann Shumilova <ashumilova@codenvy.com>
@ashumilova ashumilova added this to the 5.5.0 milestone Mar 9, 2017
@ashumilova ashumilova self-assigned this Mar 9, 2017
@slemeur
Copy link
Contributor

slemeur commented Mar 9, 2017

Seems that the CQ is for version 1.4.7 and we are using 1.4.8. Should update the CQ

@benoitf
Copy link
Contributor

benoitf commented Mar 9, 2017

we should piggy back https://dev.eclipse.org/ipzilla/show_bug.cgi?id=10849

@slemeur
Copy link
Contributor

slemeur commented Mar 9, 2017

+1 for the piggy back

@benoitf
Copy link
Contributor

benoitf commented Mar 9, 2017

I would say it depends on the urgency
urgent : downgrade to 1.4.7
low priority : add PB on CQ to 1.4.8

@ashumilova
Copy link
Contributor Author

1.4.7 - doesn't work - checked just now

@codenvy-ci
Copy link

Build finished.
Build # 2137 - FAILED

Please check console output at $BUILD_URL to view the results.

@codenvy-ci
Copy link

Build # 2137 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2137/ to view the results.

@ashumilova
Copy link
Contributor Author

@slemeur
Copy link
Contributor

slemeur commented Mar 9, 2017

Build is currently broken due to this transitive dependency.

As it's a piggy back CQ and already approved by PMC for ecd.che, the CQ will take few time before being completely cleared, but there is no risk that the CQ will not be approved.

I'm OK to merge the PR in order to resolve the broken build.

@ashumilova ashumilova merged commit 0c0379f into master Mar 9, 2017
@ashumilova ashumilova deleted the fix_build branch March 9, 2017 09:26
@ashumilova
Copy link
Contributor Author

Thank you

@JamesDrummond JamesDrummond mentioned this pull request Mar 17, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants