Intelligent Commands bug fixes and code refactoring #4745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2423/ |
vparfonov
approved these changes
Apr 10, 2017
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
* fix resetting a default command after any command modifications; * fix tooltip for Execute Command button in case more than one machine is launching in the workspace; * fix NPE on opening Commands Palette; * add events for listening to commands modifications: CommandAddedEvent, CommandRemovedEvent, CommandUpdatedEvent, CommandsLoadedEvent; minor code refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes several bugs related to Execute Command buttons on Commands toolbar.
More precisely:
What issues does this PR fix or reference?
#4674
#4625
Changelog
Fixes several bugs related to Execute Command buttons on Commands toolbar
Release Notes
Introduced events for listening to commands modifications:
Docs PR
N/A