Fix Maven dependency manangement: Use ${che.version} instead of ${project.version} to allow projects with different version to use Che dependencies. #4752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion} to allow projects with different version to use Che dependencies Signed-off-by: Sun Seng David Tan <sutan@redhat.com>
skabashnyuk
approved these changes
Apr 10, 2017
|
what about this one https://github.com/sunix/che/blob/a5539bbab232464a14282eb6cc15d3df75d19eb5/pom.xml#L859 ? |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2425/ |
|
@riuvshin thanks ... :) will fixup |
…oject.version} to allow projects with different version to use Che dependencies Signed-off-by: Sun Seng David Tan <sutan@redhat.com>
riuvshin
approved these changes
Apr 10, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2430/ |
JamesDrummond
added
the
target/branch
|
@JamesDrummond why |
JamesDrummond
removed
the
target/branch
|
My mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix Maven dependency manangement: Use ${che.version} instead of ${project.version} to allow projects with different version to use Che dependencies.
What issues does this PR fix or reference?
Updates #1335
Changelog
Fix Maven dependency manangement: Use ${che.version} instead of ${project.version} to allow projects with different version to use Che dependencies.
Release Notes
Docs PR