Do not set debug log level when debug flag is used #4860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unset debug level when --debug is used to not use it as default behavior. To set debug log level use env variable from CLI help.
garagatyi
added
the
kind/task
garagatyi
requested review from
benoitf and
skabashnyuk
and removed request for
benoitf
skabashnyuk
approved these changes
Apr 20, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2472/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unset debug level when --debug is used to not use it as default behavior.
To set debug log level use env variable from CLI help.
Also not setting CHE_LOG_LEVEL doesn't work because of the default issue, so this PR fixes this behavior.
Changelog
Do not use debug log level as default when master debug mode is enabled.
Release Notes
Docs PR