CHE-4670: make copy file operation more informative #4926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhukovs
reviewed
Apr 26, 2017
| @@ -544,7 +544,9 @@ private NewProjectConfigDto asDto(MutableProjectConfig config) { | |||
| checkArgument(!source.getLocation().isRoot(), "Workspace root is not allowed to be copied"); | |||
There was a problem hiding this comment.
translate this statement with using return promises.reject(...)
There was a problem hiding this comment.
In this class we have many validations like this:
checkArgument(expression, errorMessage)
So, I think we should change many of them but not in this issue.
vzhukovs
approved these changes
Apr 26, 2017
vparfonov
approved these changes
Apr 26, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2518/ |
slemeur
added
the
kind/enhancement
|
@vparfonov For this kind of PR, you need to notify PM. and request approval Could we change the messages to:
|
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes copy file operation more informative.
If a file with its name already exists the window will be shown:
What issues does this PR fix or reference?
#4670
Changelog
Make copy file operation more informative