CHE-4942: fix text overlapping on Configure Actions on Factory details page. #4944
Conversation
…s page. Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
akurinnoy
added
the
kind/bug
| ng-model="factoryActionBoxCtrl.selectedParam"> | ||
| <div ng-message="required">Param is required.</div> | ||
| <div ng-message="maxlength">The value has to be less than 255 characters long.</div> |
There was a problem hiding this comment.
doest it require as well md-maxlength ?
There was a problem hiding this comment.
minor issue: is the length is 255 or 256 ? it seems sometimes we have 256 and sometimes 255 (as message is less than, it doesn't include equals)
There was a problem hiding this comment.
doest it require as well md-maxlength ?
AFAIK, directive ngMaxlength adds maxlength validator to ngModel,
so, it doesn't require any other validator
255 or 256
I've tried to add action with length equal 256 symbols and got the error.
There was a problem hiding this comment.
AFAIK it is in case when you use element as a child of a
https://github.com/angular/material/blob/7e211188ae33171d527921a59e001fa9e311394d/src/components/input/input.js#L172
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2525/ |
…s page. (eclipse-che#4944) Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
…s page. (#4944) Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
What does this PR do?
What issues does this PR fix or reference?
#4942
Changelog
[UD] fixed text overlapping on Configure Actions on Factory details page.
Release Notes
N/A - bugfix
Docs PR
N/A - bugfix
Signed-off-by: Oleksii Kurinnyi okurinnyi@codenvy.com