CHE-4939: Fix bugs related to processing of read-only files #5003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhukovs
reviewed
May 4, 2017
| ResourceDelta delta = event.getDelta(); | ||
| Path resourceLocation = delta.getResource().getLocation(); | ||
|
|
||
| if (project.equals(resourceLocation) && REMOVED == delta.getKind()) { |
There was a problem hiding this comment.
Check for delta kind at first, then for equality of resources. It will be faster than this condition.
vzhukovs
reviewed
May 4, 2017
|
|
||
| private void removeHandlers() { | ||
| if (fileEventHandlerRegistration != null) { | ||
| fileEventHandlerRegistration.removeHandler(); |
There was a problem hiding this comment.
Set fileEventHandlerRegistration to null.
vzhukovs
reviewed
May 4, 2017
| } | ||
|
|
||
| if (resourceChangeHandlerRegistration != null) { | ||
| resourceChangeHandlerRegistration.removeHandler(); |
There was a problem hiding this comment.
Set resourceChangeHandlerRegistration to null also.
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2543/ |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2547/ |
vparfonov
approved these changes
May 10, 2017
Signed-off-by: Roman Nikitenko <rnikitenko@codenvy.com>
|
Build # 2604 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2604/ to view the results. |
slemeur
added
the
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roman Nikitenko rnikitenko@codenvy.com
What does this PR do?
Fix bugs related to processing of read-only files:
What issues does this PR fix or reference?
#4939
Changelog
Fix bugs related to processing of read-only files