Unification of JSON RPC codebase #5005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkuleshov
added
the
status/in-progress
|
Build # 2544 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2544/ to view the results. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2548/ |
dkuleshov
force-pushed
the
jsonrpc-source-merge
branch
from
11db683
to
f5dff5f
Compare
|
Build # 2558 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2558/ to view the results. |
dkuleshov
added
status/code-review
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2559/ |
vparfonov
approved these changes
May 11, 2017
| * Serializes JSON RPC request object into a string | ||
| * | ||
| * @param request | ||
| * response |
| * <li>{@link OneToManyHandler}- to receive a request with a single parameter and multiple results </li> | ||
| * <li>{@link ManyToNoneHandler} - to receive a notification with multiple parameters</li> | ||
| * <li>{@link ManyToOneHandler} - to receive request with multiple parameters and a single result</li> | ||
| * <li>{@link ManyToManyHandler} - to receive request with multiple parameters and mu</li> |
There was a problem hiding this comment.
the sentence is not finished, I suppose: "...and multiple results"
RomanNikitenko
approved these changes
May 11, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2569/ |
svor
approved these changes
May 12, 2017
|
Build # 2580 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2580/ to view the results. |
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
dkuleshov
force-pushed
the
jsonrpc-source-merge
branch
from
77d59ed
to
f1fe41c
Compare
added 2 commits
May 15, 2017 17:56
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
skabashnyuk
approved these changes
May 15, 2017
| @@ -8,12 +8,12 @@ | |||
| * Contributors: | |||
| * Codenvy, S.A. - initial API and implementation | |||
| *******************************************************************************/ | |||
| package org.eclipse.che.api.core.jsonrpc; | |||
| package org.eclipse.che.api.core.jsonrpc.commons; | |||
|
|
|||
| * <li>{@link ManyToManyHandler} - to receive request with multiple parameters and multiple results</li> | ||
| * </ul> | ||
| */ | ||
| @Singleton |
There was a problem hiding this comment.
think about if this class is thread safe
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
|
Build # 2595 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2595/ to view the results. |
Signed-off-by: Vitalii Parfonov <vparfonov@codenvy.com>
Signed-off-by: Dmitry Kuleshov <dkuleshov@codenvy.com>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2602/ |
slemeur
added
the
kind/enhancement
benoitf
removed
the
status/code-review
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We had two different implementations of JSON RPC subsystem because of different Java version used on client and server side. After we updated java version on client we no more need different implementations. This PR is intended to make code base as unified as possible for both sides. More accurately current difference is mostly within JSON parsing libraries (which are different for client and server sides).
What issues does this PR fix or reference?
#4616
Changelog
Client side (IDE) and server side (workspace agent, workspace master) JSON RPC services codebase is unified
Release Notes
Client side (IDE) and server side (workspace agent, workspace master) JSON RPC services codebase is unified