Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODENVY-2035: Change doc's links #5033

Merged
merged 1 commit into from
May 10, 2017
Merged

CODENVY-2035: Change doc's links #5033

merged 1 commit into from
May 10, 2017

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented May 10, 2017

Signed-off-by: Oleksii Orel oorel@codenvy.com

What does this PR do?

Change doc's links

What issues does this PR fix or reference?

codenvy/codenvy#2035

Changelog

-- Change doc's links.

@@ -11,7 +11,7 @@

-->
<che-toolbar che-title="Workspaces" border-none></che-toolbar>
<che-description che-link-title="Learn more." che-link="/docs/workspace/admin-intro/index.html">A workspace is where your projects live and run. Create workspaces from stacks that define projects, runtimes, and commands.</che-description>
<che-description che-link-title="Learn more." che-link="{{branding.docs.worskpace}}">A workspace is where your projects live and run. Create workspaces from stacks that define projects, runtimes, and commands.</che-description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo
worskpace => workspace

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

},
"docs" : {
"stack" : "/docs/devops/runtime-stacks/index.html",
"worskpace" : "/docs/devops/intro/index.html"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -21,6 +21,7 @@ export class CheBranding {
$http: ng.IHttpService;
cheService: CheService;

private docs: { stack: string; worskpace: string};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Oleksii Orel <oorel@codenvy.com>
@olexii4
Copy link
Contributor Author

olexii4 commented May 10, 2017

Not yet. They are in progress. 5 min

@ashumilova ashumilova added the kind/bug Outline of a bug - must adhere to the bug report template. label May 10, 2017
@ashumilova ashumilova added this to the 5.10.0 milestone May 10, 2017
@olexii4
Copy link
Contributor Author

olexii4 commented May 10, 2017

codenvy/codenvy#2176

@olexii4
Copy link
Contributor Author

olexii4 commented May 10, 2017

@olexii4 olexii4 merged commit af94281 into master May 10, 2017
@olexii4 olexii4 deleted the CODENVY-2035 branch May 10, 2017 10:36
@codenvy-ci
Copy link

Build # 2557 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2557/ to view the results.

JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants